Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: chrome/browser/extensions/convert_web_app_browsertest.cc

Issue 7003098: Start refractoring extension permissions into ExtensionPermissionSet. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix a bad merge Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/convert_web_app_browsertest.cc
diff --git a/chrome/browser/extensions/convert_web_app_browsertest.cc b/chrome/browser/extensions/convert_web_app_browsertest.cc
index e4985dfe2532911a8307f593ae7b62b92fda05ae..cd30206925d8f80cd2ab6a5e7b16a32a2d936cca 100644
--- a/chrome/browser/extensions/convert_web_app_browsertest.cc
+++ b/chrome/browser/extensions/convert_web_app_browsertest.cc
@@ -70,11 +70,11 @@ IN_PROC_BROWSER_TEST_F(ExtensionFromWebAppTest, Basic) {
EXPECT_EQ(extension_misc::LAUNCH_PANEL,
installed_extension_->launch_container());
- ASSERT_EQ(2u, installed_extension_->api_permissions().size());
- EXPECT_TRUE(installed_extension_->api_permissions().find("geolocation") !=
- installed_extension_->api_permissions().end());
- EXPECT_TRUE(installed_extension_->api_permissions().find("notifications") !=
- installed_extension_->api_permissions().end());
+ ASSERT_EQ(2u, installed_extension_->permission_set().apis().size());
+ EXPECT_TRUE(installed_extension_->HasApiPermission(
+ ExtensionAPIPermission::Geolocation()));
+ EXPECT_TRUE(installed_extension_->HasApiPermission(
+ ExtensionAPIPermission::Notification()));
ASSERT_EQ(3u, installed_extension_->icons().map().size());
EXPECT_EQ("icons/16.png", installed_extension_->icons().Get(

Powered by Google App Engine
This is Rietveld 408576698