Start refractoring extension permissions into ExtensionPermissionSet.

chrome/browser/extensions/extension_prefs.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_PREFS_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_PREFS_H_
 #pragma once
 
 #include <set>
 #include <string>
@@ skipping 155 matching lines @@
   base::Time LastActivePingDay(const std::string& extension_id);
   void SetLastActivePingDay(const std::string& extension_id,
                             const base::Time& time);
 
   // A bit we use for determining if we should send the "days since active"
   // ping. A value of true means the item has been active (launched) since the
   // last update check.
   bool GetActiveBit(const std::string& extension_id);
   void SetActiveBit(const std::string& extension_id, bool active);
 
-  // Gets the permissions (|api_permissions|, |host_extent| and |full_access|)
-  // granted to the extension with |extension_id|. |full_access| will be true
-  // if the extension has all effective permissions (like from an NPAPI plugin).
-  // Returns false if the granted permissions haven't been initialized yet.
-  // TODO(jstritar): Refactor the permissions into a class that encapsulates
-  // all granted permissions, can be initialized from preferences or
-  // a manifest file, and can be compared to each other.
-  bool GetGrantedPermissions(const std::string& extension_id,
-                             bool* full_access,
-                             std::set<std::string>* api_permissions,
-                             URLPatternSet* host_extent);
+  // Returns the granted permission set for the extension with |extension_id|.
+  // This sets |initialized| to true (when not NULL) if the extension's granted
+  // permissions have been initialized (to help distinguish between empty
+  // permission sets and new extensions).
+  // This passes ownership of the returned set to the caller.
+  ExtensionPermissionSet* GetGrantedPermissions(
+      const std::string& extension_id, bool* initialized);
 
-  // Adds the specified |api_permissions|, |host_extent| and |full_access|
-  // to the granted permissions for extension with |extension_id|.
-  // |full_access| should be set to true if the extension effectively has all
-  // permissions (such as by having an NPAPI plugin).
+  // Adds the |permissions| to the granted permissions set for the extension
+  // with |extension_id|. The new granted permissions set will be the union
+  // of the already granted permissions and |permissions|.
   void AddGrantedPermissions(const std::string& extension_id,
-                             const bool full_access,
-                             const std::set<std::string>& api_permissions,
-                             const URLPatternSet& host_extent);
+                             const ExtensionPermissionSet& permissions);
 
   // Returns true if the user enabled this extension to be loaded in incognito
   // mode.
   bool IsIncognitoEnabled(const std::string& extension_id);
   void SetIsIncognitoEnabled(const std::string& extension_id, bool enabled);
 
   // Returns true if the user has chosen to allow this extension to inject
   // scripts into pages with file URLs.
   bool AllowFileAccess(const std::string& extension_id);
   void SetAllowFileAccess(const std::string& extension_id, bool allow);
@@ skipping 194 matching lines @@
 
   // Reads a list pref |pref_key| as a string set from the extension with
   // id |extension_id|.
   bool ReadExtensionPrefStringSet(const std::string& extension_id,
                                   const std::string& pref_key,
                                   std::set<std::string>* result);
 
   // Adds the |added_values| to the value of |pref_key| for the extension
   // with id |extension_id| (the new value will be the union of the existing
   // value and |added_values|).
-  void AddToExtensionPrefStringSet(const std::string& extension_id,
-                                   const std::string& pref_key,
-                                   const std::set<std::string>& added_values);
+  void SetExtensionPrefStringSet(const std::string& extension_id,
+                                 const std::string& pref_key,
+                                 const std::set<std::string>& added_values);
 
   // Returns a dictionary for extension |id|'s prefs or NULL if it doesn't
   // exist.
   const DictionaryValue* GetExtensionPref(const std::string& id) const;
 
   // Returns the dictionary of preferences controlled by the specified extension
   // or creates a new one. All entries in the dictionary contain non-expanded
   // paths.
   const DictionaryValue* GetExtensionControlledPrefs(
       const std::string& id,
@@ skipping 28 matching lines @@
 
   scoped_ptr<ExtensionContentSettingsStore> content_settings_store_;
 
   // The URLs of all of the toolstrips.
   URLList shelf_order_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionPrefs);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_PREFS_H_