Start refractoring extension permissions into ExtensionPermissionSet.

chrome/common/extensions/url_pattern_set.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/url_pattern_set.h"
 
 #include "chrome/common/extensions/url_pattern.h"
 #include "googleurl/src/gurl.h"
 
+// static
+void URLPatternSet::CreateUnion(const URLPatternSet& set1,
+                                const URLPatternSet& set2,
+                                URLPatternSet* out) {
+  const URLPatternList list1 = set1.patterns();
+  const URLPatternList list2 = set2.patterns();
+
+  out->ClearPatterns();
+
+  // TODO(jstritar): This would be a lot easier if URLPattern had == overrided.
+  for (size_t i = 0; i < list1.size(); ++i) {
+    bool duplicate = false;
+    for (size_t j = 0; j < out->patterns().size(); ++j) {
+      if (list1.at(i).GetAsString() == out->patterns().at(j).GetAsString()) {
+        duplicate = true;
+        break;
+      }
+    }
+    if (!duplicate)

[Matt Perry, 2011/06/21 00:43:10]

is there a strong reason to strip duplicates? if not, I'd say just let them
happen.

[jstritar, 2011/06/21 23:12:16]

It doesn't really matter, except that they'll accumulate in the prefs. I got rid
of the duplicate checks here, and modified
ExtensionPrefs::SetExtensionPrefURLPatternSet to not store duplicates.
Done.

+      out->AddPattern(list1.at(i));
+  }
+
+  for (size_t i = 0; i < list2.size(); ++i) {
+    bool duplicate = false;
+    for (size_t j = 0; j < out->patterns().size(); ++j) {
+      if (list2.at(i).GetAsString() == out->patterns().at(j).GetAsString()) {
+        duplicate = true;
+        break;
+      }
+    }
+    if (!duplicate)
+      out->AddPattern(list2.at(i));
+  }
+}
+
 URLPatternSet::URLPatternSet() {
 }
 
 URLPatternSet::URLPatternSet(const URLPatternSet& rhs)
     : patterns_(rhs.patterns_) {
 }
 
 URLPatternSet::~URLPatternSet() {
 }
 
@@ skipping 31 matching lines @@
        i != patterns_.end(); ++i) {
     for (URLPatternList::const_iterator j = other.patterns().begin();
          j != other.patterns().end(); ++j) {
       if (i->OverlapsWith(*j))
         return true;
     }
   }
 
   return false;
 }