Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issue 7003090: Add histograms to measure DNS lookups for different configurations. (Closed)

Created:
9 years, 6 months ago by Mike Belshe
Modified:
9 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Add histograms to measure DNS lookups for different configurations. When we request the address family IPV4, we're asking for A records only. When we ask for family UNSPEC, we're asking for both A and AAAA records. Let's see if there is a latency difference. BUG=none TEST=n/a Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88675

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M net/base/host_resolver_impl.cc View 1 2 chunks +27 lines, -0 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
Mike Belshe
9 years, 6 months ago (2011-06-09 16:57:11 UTC) #1
jar (doing other things)
LGTM Optional nit to consider below. http://codereview.chromium.org/7003090/diff/3001/net/base/host_resolver_impl.cc File net/base/host_resolver_impl.cc (right): http://codereview.chromium.org/7003090/diff/3001/net/base/host_resolver_impl.cc#newcode675 net/base/host_resolver_impl.cc:675: break; nit: perchance ...
9 years, 6 months ago (2011-06-09 18:30:00 UTC) #2
cbentzel
9 years, 6 months ago (2011-06-09 18:47:03 UTC) #3
Driveby comment-on-comment [this LGTM if it matters]

http://codereview.chromium.org/7003090/diff/3001/net/base/host_resolver_impl.cc
File net/base/host_resolver_impl.cc (right):

http://codereview.chromium.org/7003090/diff/3001/net/base/host_resolver_impl....
net/base/host_resolver_impl.cc:675: break;
On 2011/06/09 18:30:00, jar wrote:
> nit: perchance add a default: NOT_REACHED.
> 
> The style guide suggests this for non-enumerated cases, but also claims that
in
> enumerated cases the compiler will warn.... but I doubt our compiler provides
> such a warning.

I've had compiler warnings for that case [I believe gcc on Linux does, perhaps
others].

Powered by Google App Engine
This is Rietveld 408576698