Print Preview: Changing displayed error message when PDF Viewer is missing.

chrome/browser/resources/print_preview.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var localStrings = new LocalStrings();
 
 // The total page count of the previewed document regardless of which pages the
 // user has selected.
 var totalPageCount = -1;
 
@@ skipping 24 matching lines @@
 
 /**
  * Window onload handler, sets up the page and starts print preview by getting
  * the printer list.
  */
 function onLoad() {
   $('system-dialog-link').addEventListener('click', showSystemDialog);
   $('cancel-button').addEventListener('click', handleCancelButtonClick);
 
   if (!checkCompatiblePluginExists()) {
-    displayErrorMessage(localStrings.getString('noPlugin'), false);
+    var errorButton = $('error-button');
+    errorButton.onclick = showSystemDialog;
+    errorButton.innerHTML = localStrings.getString('launchNativeDialog');

[James Hawkins, 2011/06/09 16:59:52]

s/innerHTML/value/

It's just text.

[dpapad, 2011/06/09 17:21:25]

I tried value, but strangely it does not set the text.

+    displayErrorMessage(localStrings.getString('noPlugin'), true);
     $('mainview').parentElement.removeChild($('dummy-viewer'));
     return;
   }
   $('mainview').parentElement.removeChild($('dummy-viewer'));
 
   $('printer-list').disabled = true;
   $('print-button').disabled = true;
   showLoadingAnimation();
   chrome.send('getDefaultPrinter');
 }
@@ skipping 78 matching lines @@
 function showSystemDialog() {
   chrome.send('showSystemDialog');
 }
 
 /**
  * Disables the controls which need the initiator tab to generate preview
  * data. This function is called when the initiator tab is closed.
  * @param {string} initiatorTabURL The URL of the initiator tab.
  */
 function onInitiatorTabClosed(initiatorTabURL) {
-  $('reopen-page').addEventListener('click', function() {
-      window.location = initiatorTabURL;
-  });
+  var errorButton = $('error-button');
+  errorButton.innerHTML = localStrings.getString('reopenPage');
+  errorButton.onclick = function() { window.location = initiatorTabURL; };
   displayErrorMessage(localStrings.getString('initiatorTabClosed'), true);
 }
 
 /**
  * Gets the selected printer capabilities and updates the controls accordingly.
  */
 function updateControlsWithSelectedPrinterCapabilities() {
   var printerList = $('printer-list');
   var selectedIndex = printerList.selectedIndex;
   if (selectedIndex < 0)
@@ skipping 273 matching lines @@
   var pdfViewer = $('pdf-viewer');
   if (!pdfViewer) {
     return;
   }
   pdfViewer.grayscale(!color);
 }
 
 /**
  * Display an error message in the center of the preview area.
  * @param {string} errorMessage The error message to be displayed.
- * @param {boolean} showButton Indivates whether the "Reopen the page" button
- * should be displayed.
+ * @param {boolean} showButton Indicates whether the error-button should be

[James Hawkins, 2011/06/09 16:59:52]

This is fragile; just have the call site show the button.

[dpapad, 2011/06/09 17:21:25]

Done. Made it a little more flexible.

+ * displayed. Callers of this function have the responsibility to attach a
+ * listener to the button and also set the displayed text before calling this
+ * function.
  */
 function displayErrorMessage(errorMessage, showButton) {
   $('overlay-layer').classList.remove('invisible');
   $('dancing-dots-text').classList.add('hidden');
   $('error-text').innerHTML = errorMessage;
   $('error-text').classList.remove('hidden');
   if (showButton)
-    $('reopen-page').classList.remove('hidden');
+    $('error-button').classList.remove('hidden');
   else
-    $('reopen-page').classList.add('hidden');
+    $('error-button').classList.add('hidden');
 
   removeEventListeners();
   var pdfViewer = $('pdf-viewer');
   if (pdfViewer)
     $('mainview').removeChild(pdfViewer);
 }
 
 /**
  * Display an error message when print preview fails.
  * Called from PrintPreviewMessageHandler::OnPrintPreviewFailed().
@@ skipping 493 matching lines @@
   this.isLandscape = '';
 }
 
 /**
  * Takes a snapshot of the print settings.
  */
 PrintSettings.prototype.save = function() {
   this.deviceName = getSelectedPrinterName();
   this.isLandscape = isLandscape();
 }