Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7003089: Print Preview: Changing displayed error message when PDF Viewer is missing. (Closed)

Created:
9 years, 6 months ago by dpapad
Modified:
9 years, 6 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Print Preview: Changing displayed error message when PDF Viewer is missing. BUG=85383 TEST=Launch print preview without having the plugin. A new error message should be displayed, including a button offering to launch the native print dialog. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88611

Patch Set 1 #

Total comments: 4

Patch Set 2 : Moving string declaration outside ifder. #

Patch Set 3 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -17 lines) Patch
M chrome/app/chromium_strings.grd View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/resources/print_preview.html View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/print_preview.js View 1 2 4 chunks +26 lines, -14 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_data_source.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dpapad
9 years, 6 months ago (2011-06-09 16:54:22 UTC) #1
James Hawkins
http://codereview.chromium.org/7003089/diff/1/chrome/browser/resources/print_preview.js File chrome/browser/resources/print_preview.js (right): http://codereview.chromium.org/7003089/diff/1/chrome/browser/resources/print_preview.js#newcode47 chrome/browser/resources/print_preview.js:47: errorButton.innerHTML = localStrings.getString('launchNativeDialog'); s/innerHTML/value/ It's just text. http://codereview.chromium.org/7003089/diff/1/chrome/browser/resources/print_preview.js#newcode443 chrome/browser/resources/print_preview.js:443: ...
9 years, 6 months ago (2011-06-09 16:59:52 UTC) #2
dpapad
http://codereview.chromium.org/7003089/diff/1/chrome/browser/resources/print_preview.js File chrome/browser/resources/print_preview.js (right): http://codereview.chromium.org/7003089/diff/1/chrome/browser/resources/print_preview.js#newcode47 chrome/browser/resources/print_preview.js:47: errorButton.innerHTML = localStrings.getString('launchNativeDialog'); On 2011/06/09 16:59:52, James Hawkins wrote: ...
9 years, 6 months ago (2011-06-09 17:21:25 UTC) #3
James Hawkins
LGTM
9 years, 6 months ago (2011-06-09 19:59:09 UTC) #4
commit-bot: I haz the power
9 years, 6 months ago (2011-06-09 23:28:38 UTC) #5 
Change committed as 88611

Powered by Google App Engine
This is Rietveld 408576698