Chromium Code Reviews

Issue 7003087: Simplify the check when to perform loop invariant code motion. (Closed)

Created:
9 years, 6 months ago by fschneider
Modified:
9 years, 6 months ago
Reviewers:
Kevin Millikin (Chromium)
CC:
v8-dev
Visibility:
Public.

Description

Simplify the check when to perform loop invariant code motion. Allow HChange instructions to be hoisted out of loops. To avoid unnecessary code motion we don't hoist instructions from blocks that have been marked containing an unconditional deoptimization. Committed: http://code.google.com/p/v8/source/detail?r=8245

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Stats (+28 lines, -36 lines)
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments
M src/hydrogen.h View 3 chunks +5 lines, -0 lines 0 comments
M src/hydrogen.cc View 9 chunks +23 lines, -34 lines 0 comments

Messages

Total messages: 4 (0 generated)
fschneider
9 years, 6 months ago (2011-06-09 15:06:17 UTC) #1
Kevin Millikin (Chromium)
As discussed offline, we might need to propagate this flag to dominated blocks. http://codereview.chromium.org/7003087/diff/1/src/hydrogen.cc File ...
9 years, 6 months ago (2011-06-09 15:18:00 UTC) #2
fschneider
Addressed comments. http://codereview.chromium.org/7003087/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/7003087/diff/1/src/hydrogen.cc#newcode1452 src/hydrogen.cc:1452: if (!AllowCodeMotion()) return false; On 2011/06/09 15:18:00, ...
9 years, 6 months ago (2011-06-09 15:46:47 UTC) #3
Kevin Millikin (Chromium)
9 years, 6 months ago (2011-06-09 15:48:44 UTC) #4
LGTM.

Powered by Google App Engine