Fix crash when you uninstall a permissions-upgrade disabled extension.

Fix crash when you uninstall a permissions-upgrade disabled extension.

When an extension is disabled because a newer version requires higher
permissions, if you then uninstall the extension while the infobar warning
is still up, you'll get a crash if you switch to the tab that had the infobar.
This patch makes the infobar notice the extension uninstall and remove itself.

BUG=84826
TEST=As detailed in description above (and outlined in bug report too).


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88458

[Mihai Parparita -not on Chrome, 2011-06-08 23:20:44]

LGTM

http://codereview.chromium.org/7003068/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_disabled_infobar_delegate.cc (right):

http://codereview.chromium.org/7003068/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_disabled_infobar_delegate.cc:161: if
(info->reason == UnloadedExtensionInfo::DISABLE ||
Won't this leave extension uninitialized if it's not a disable or uninstall? Is
there a compiler warning about that?

[asargent_no_longer_on_chrome, 2011-06-08 23:40:12]

> Won't this leave extension uninitialized if it's not a disable or uninstall?
Is
> there a compiler warning about that?

Good catch.

[commit-bot: I haz the power, 2011-06-09 01:18:43]

Change committed as 88458