Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 7003066: GTK: Add CHECKs() to try to find the cause of a GlobalBookmarkMenu crash. (Closed)

Created:
9 years, 6 months ago by Elliot Glaysher
Modified:
9 years, 6 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

GTK: Add CHECKs() to try to find the cause of a GlobalBookmarkMenu crash. (Also moves the image forcing to after the image is set so it doesn't get reset.) BUG=85443 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88412

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M chrome/browser/ui/gtk/global_bookmark_menu.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/global_bookmark_menu.cc View 4 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
9 years, 6 months ago (2011-06-08 21:19:14 UTC) #1
Lei Zhang
9 years, 6 months ago (2011-06-08 21:43:19 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698