Add placeholder chrome://media-internals page.

Add placeholder chrome://media-internals page.

This page will eventually contain detailed media information, much like sync-,
gpu-, and net-internals.

BUG=none
TEST=Navigate to chrome://media-internals.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89769

[Scott Franklin, 2011-06-09 19:26:15]

For owners.

[scherkus (not reviewing), 2011-06-14 02:21:34]

few comments

we'll need arv@ to comment on the rest for OWNERS goodness

http://codereview.chromium.org/7003064/diff/1/chrome/browser/resources/media_...
File chrome/browser/resources/media_internals.html (right):

http://codereview.chromium.org/7003064/diff/1/chrome/browser/resources/media_...
chrome/browser/resources/media_internals.html:4: Copyright (c) 2010 The Chromium
Authors. All rights reserved.
2011

http://codereview.chromium.org/7003064/diff/1/chrome/browser/resources/media_...
chrome/browser/resources/media_internals.html:16: 
nit: remove blank line

http://codereview.chromium.org/7003064/diff/1/chrome/browser/ui/webui/media_i...
File chrome/browser/ui/webui/media_internals_ui.cc (right):

http://codereview.chromium.org/7003064/diff/1/chrome/browser/ui/webui/media_i...
chrome/browser/ui/webui/media_internals_ui.cc:17: #include
"chrome/common/jstemplate_builder.h"
I don't think you need all of these header file includes

can you trim down this list to the bare minimum?

http://codereview.chromium.org/7003064/diff/1/chrome/browser/ui/webui/media_i...
chrome/browser/ui/webui/media_internals_ui.cc:33: virtual std::string
GetMimeType(const std::string&) const;
param name?

http://codereview.chromium.org/7003064/diff/1/chrome/browser/ui/webui/media_i...
chrome/browser/ui/webui/media_internals_ui.cc:36: ~MediaInternalsHTMLSource() {}
should be virtual

http://codereview.chromium.org/7003064/diff/1/chrome/browser/ui/webui/media_i...
File chrome/browser/ui/webui/media_internals_ui.h (right):

http://codereview.chromium.org/7003064/diff/1/chrome/browser/ui/webui/media_i...
chrome/browser/ui/webui/media_internals_ui.h:13: public:
indent by 1 space not two

http://codereview.chromium.org/7003064/diff/1/chrome/browser/ui/webui/media_i...
chrome/browser/ui/webui/media_internals_ui.h:14: explicit
MediaInternalsUI(TabContents* contents);
indent by 2 spaces

http://codereview.chromium.org/7003064/diff/1/chrome/browser/ui/webui/media_i...
chrome/browser/ui/webui/media_internals_ui.h:16:
DISALLOW_COPY_AND_ASSIGN(MediaInternalsUI);
this should be in a private section (which is why we're disallowing them)

http://codereview.chromium.org/7003064/diff/1/chrome/browser/ui/webui/media_i...
chrome/browser/ui/webui/media_internals_ui.h:20: 
remove blank line

http://codereview.chromium.org/7003064/diff/1/chrome/test/functional/special_...
File chrome/test/functional/special_tabs.py (right):

http://codereview.chromium.org/7003064/diff/1/chrome/test/functional/special_...
chrome/test/functional/special_tabs.py:38: 'chrome://media-internals': 'Media
Internals',
this looks like it should be in alphabetical order

[Scott Franklin, 2011-06-14 17:16:50]

Also rebased and resolved list-ordering conflicts.

http://codereview.chromium.org/7003064/diff/1/chrome/browser/resources/media_...
File chrome/browser/resources/media_internals.html (right):

http://codereview.chromium.org/7003064/diff/1/chrome/browser/resources/media_...
chrome/browser/resources/media_internals.html:4: Copyright (c) 2010 The Chromium
Authors. All rights reserved.
On 2011/06/14 02:21:34, scherkus wrote:
> 2011

Done.

http://codereview.chromium.org/7003064/diff/1/chrome/browser/resources/media_...
chrome/browser/resources/media_internals.html:16: 
On 2011/06/14 02:21:34, scherkus wrote:
> nit: remove blank line

Done.

http://codereview.chromium.org/7003064/diff/1/chrome/browser/ui/webui/media_i...
File chrome/browser/ui/webui/media_internals_ui.cc (right):

http://codereview.chromium.org/7003064/diff/1/chrome/browser/ui/webui/media_i...
chrome/browser/ui/webui/media_internals_ui.cc:17: #include
"chrome/common/jstemplate_builder.h"
On 2011/06/14 02:21:34, scherkus wrote:
> I don't think you need all of these header file includes
> 
> can you trim down this list to the bare minimum?

Done.

http://codereview.chromium.org/7003064/diff/1/chrome/browser/ui/webui/media_i...
chrome/browser/ui/webui/media_internals_ui.cc:33: virtual std::string
GetMimeType(const std::string&) const;
On 2011/06/14 02:21:34, scherkus wrote:
> param name?

Done.

http://codereview.chromium.org/7003064/diff/1/chrome/browser/ui/webui/media_i...
chrome/browser/ui/webui/media_internals_ui.cc:36: ~MediaInternalsHTMLSource() {}
On 2011/06/14 02:21:34, scherkus wrote:
> should be virtual

Done.

http://codereview.chromium.org/7003064/diff/1/chrome/browser/ui/webui/media_i...
File chrome/browser/ui/webui/media_internals_ui.h (right):

http://codereview.chromium.org/7003064/diff/1/chrome/browser/ui/webui/media_i...
chrome/browser/ui/webui/media_internals_ui.h:13: public:
On 2011/06/14 02:21:34, scherkus wrote:
> indent by 1 space not two

Done.

http://codereview.chromium.org/7003064/diff/1/chrome/browser/ui/webui/media_i...
chrome/browser/ui/webui/media_internals_ui.h:14: explicit
MediaInternalsUI(TabContents* contents);
On 2011/06/14 02:21:34, scherkus wrote:
> indent by 2 spaces

Done.

http://codereview.chromium.org/7003064/diff/1/chrome/browser/ui/webui/media_i...
chrome/browser/ui/webui/media_internals_ui.h:16:
DISALLOW_COPY_AND_ASSIGN(MediaInternalsUI);
On 2011/06/14 02:21:34, scherkus wrote:
> this should be in a private section (which is why we're disallowing them)

Done.

http://codereview.chromium.org/7003064/diff/1/chrome/browser/ui/webui/media_i...
chrome/browser/ui/webui/media_internals_ui.h:20: 
On 2011/06/14 02:21:34, scherkus wrote:
> remove blank line

Done.

http://codereview.chromium.org/7003064/diff/1/chrome/test/functional/special_...
File chrome/test/functional/special_tabs.py (right):

http://codereview.chromium.org/7003064/diff/1/chrome/test/functional/special_...
chrome/test/functional/special_tabs.py:38: 'chrome://media-internals': 'Media
Internals',
On 2011/06/14 02:21:34, scherkus wrote:
> this looks like it should be in alphabetical order

Done.

[scherkus (not reviewing), 2011-06-14 19:05:31]

LGTM from me, just need arv/estade to look over for OWNERS goodness

[Evan Stade, 2011-06-18 00:15:10]

lgtm

[Evan Stade, 2011-06-18 00:15:24]

(forgot to publish comments)

http://codereview.chromium.org/7003064/diff/7001/chrome/browser/resources/med...
File chrome/browser/resources/media_internals.html (right):

http://codereview.chromium.org/7003064/diff/7001/chrome/browser/resources/med...
chrome/browser/resources/media_internals.html:13: <p>Placeholder page for <a
href="chrome://media-internals">chrome://media-internals</a></p>
80 applies to html as well

[Scott Franklin, 2011-06-20 18:34:45]

http://codereview.chromium.org/7003064/diff/7001/chrome/browser/resources/med...
File chrome/browser/resources/media_internals.html (right):

http://codereview.chromium.org/7003064/diff/7001/chrome/browser/resources/med...
chrome/browser/resources/media_internals.html:13: <p>Placeholder page for <a
href="chrome://media-internals">chrome://media-internals</a></p>
On 2011/06/18 00:15:25, Evan Stade wrote:
> 80 applies to html as well

Oops, didn't even see that. Done.

[commit-bot: I haz the power, 2011-06-21 00:25:51]

Change committed as 89769