Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 7003060: PrintPreview Cleanup: Rename and refactor getSelectedPagesValidity() function. (Closed)

Created:
9 years, 6 months ago by kmadhusu
Modified:
9 years, 6 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

PrintPreview Cleanup: Rename and refactor getSelectedPagesValidity() function. BUG=none TEST=Preview a webpage. Enter a page range text. If the text is invalid, an error message is displayed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88402

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -36 lines) Patch
M chrome/browser/resources/print_preview.js View 8 chunks +27 lines, -36 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
kmadhusu
9 years, 6 months ago (2011-06-08 18:47:52 UTC) #1
dpapad
http://codereview.chromium.org/7003060/diff/1/chrome/browser/resources/print_preview.js File chrome/browser/resources/print_preview.js (right): http://codereview.chromium.org/7003060/diff/1/chrome/browser/resources/print_preview.js#newcode800 chrome/browser/resources/print_preview.js:800: var successfullyParsed = 0; We don't need this variable ...
9 years, 6 months ago (2011-06-08 18:58:13 UTC) #2
dpapad
LGTM http://codereview.chromium.org/7003060/diff/1/chrome/browser/resources/print_preview.js File chrome/browser/resources/print_preview.js (right): http://codereview.chromium.org/7003060/diff/1/chrome/browser/resources/print_preview.js#newcode800 chrome/browser/resources/print_preview.js:800: var successfullyParsed = 0; On 2011/06/08 18:58:13, dpapad ...
9 years, 6 months ago (2011-06-08 20:10:06 UTC) #3
commit-bot: I haz the power
9 years, 6 months ago (2011-06-08 21:10:00 UTC) #4
Change committed as 88402

Powered by Google App Engine
This is Rietveld 408576698