Issue 7003057: Ignore empty lines in OWNERS files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7003057: Ignore empty lines in OWNERS files. (Closed)

Created:
9 years, 6 months ago by Bernhard Bauer

Modified:
9 years, 6 months ago

Reviewers:
Dirk Pranke, M-A Ruel

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Ignore empty lines in OWNERS files. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88341

Patch Set 1 #

Total comments: 1

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	owners.py	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

9 years, 6 months ago (2011-06-08 21:12:43 UTC) #3

I would have prefered this but I don't mind.

http://codereview.chromium.org/7003057/diff/1/owners.py
File owners.py (right):

http://codereview.chromium.org/7003057/diff/1/owners.py#newcode150
owners.py:150: if line.startswith('#') or line == '':
if line.startswith('#') or not line:

Expand Messages | Collapse Messages