Fix bug with GVN on array loads.

src/hydrogen-instructions.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1716 matching lines @@
 
 
 void HSimulate::Verify() {
   HInstruction::Verify();
   ASSERT(HasAstId());
 }
 
 
 void HBoundsCheck::Verify() {
   HInstruction::Verify();
-  ASSERT(HasNoUses());

[Mads Ager (chromium), 2011/06/09 10:58:50]

It seemed like a very good idea to have the assert here. Why is it gone in this
change?

[fschneider, 2011/06/09 11:03:52]

The problem is that HBoundsCheck does only have uses until we remove them in the
last phase of the graph builder, so I would need to say sth like

ASSERT(UseCount() > 0 || gvn_done)

 }
 
 
 void HCheckSmi::Verify() {
   HInstruction::Verify();
   ASSERT(HasNoUses());
 }
 
 
 void HCheckNonSmi::Verify() {
@@ skipping 21 matching lines @@
 
 
 void HCheckPrototypeMaps::Verify() {
   HInstruction::Verify();
   ASSERT(HasNoUses());
 }
 
 #endif
 
 } }  // namespace v8::internal