Issue 7003039: ui/base/models: Add empty() accessor to TreeNode class.

Issue 7003039: ui/base/models: Add empty() accessor to TreeNode class. (Closed)

Created:
9 years, 6 months ago by tfarina

Modified:
9 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, dhollowa, pam+watch_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

ui/base/models: Add empty() accessor to TreeNode class. - Replace all "child_count() == 0" with "empty()". - Change node is-empty check from "child_count() > 0" to "!empty()". BUG=None TEST=None R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88363

Patch Set 1 #

Total comments: 2

Patch Set 2 : sky review #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -10 lines)			Patch
M	chrome/browser/bookmarks/bookmark_model.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/cookies_tree_model.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_bookmark_helpers.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/importer/profile_writer.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/models/tree_node_iterator.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/models/tree_node_model.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM http://codereview.chromium.org/7003039/diff/1/ui/base/models/tree_node_model.h File ui/base/models/tree_node_model.h (right): http://codereview.chromium.org/7003039/diff/1/ui/base/models/tree_node_model.h#newcode115 ui/base/models/tree_node_model.h:115: // Returns whether the |children_| is empty. Returns ...

9 years, 6 months ago (2011-06-08 15:52:25 UTC) #2

tfarina

9 years, 6 months ago (2011-06-08 17:33:43 UTC) #3

http://codereview.chromium.org/7003039/diff/1/ui/base/models/tree_node_model.h
File ui/base/models/tree_node_model.h (right):

http://codereview.chromium.org/7003039/diff/1/ui/base/models/tree_node_model....
ui/base/models/tree_node_model.h:115: // Returns whether the |children_| is
empty.
On 2011/06/08 15:52:26, sky wrote:
> Returns true if this nodes has no children.

Done.

Expand Messages | Collapse Messages