Issue 7003036: Fix OS full-screen button on FutureCat

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7003036: Fix OS full-screen button on FutureCat (Closed)

Created:
9 years, 6 months ago by Mark Mentovai

Modified:
9 years, 6 months ago

Reviewers:
Robert Sesek, Avi (use Gerrit)

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix OS full-screen button on FutureCat. The full-screen button should trigger Chrome's full-screen mode. This should work properly even on subsequent clicks, when a window was already full-screened and then not-full-screened. BUG=85196 TEST=On FutureCat, use the full-screen button to go full-screen, then exit full-screen, then re-enter full-screen with the OS button again. Both times, Chrome's full-screen mode should be activated in the same way. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88533

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -40 lines)			Patch
M	chrome/browser/ui/cocoa/browser_window_controller.mm	View	3 chunks	+5 lines, -24 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller_private.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller_private.mm	View	3 chunks	+35 lines, -16 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages