Added a test checking for TimeFormat:: producing NaN, rolled icu version

base/test/test_util.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BASE_TEST_TEST_UTIL_H_
+#define BASE_TEST_TEST_UTIL_H_
+#pragma once
+
+// Generic utilities used only by tests.

[Paweł Hajdan Jr., 2011/06/09 08:43:22]

Please don't add yet another _util file. How about naming it scoped_locale.h?
Also, please split it into .h and .cc file, with most of the implementation in
the .cc file.

+
+#include <locale.h>
+
+#include <string>
+
+namespace base {
+
+#if defined(OS_POSIX)
+
+// Sets the given |locale| on construction, and restores the previous locale
+// on destruction.
+class ScopedSetLocale {
+ public:
+  explicit ScopedSetLocale(const char* locale) {

[Paweł Hajdan Jr., 2011/06/09 08:43:22]

nit: Could you change the type of the parameter to const std::string& or maybe
StringPiece to make it easier to pass strings there without c_str?

+    old_locale_ = setlocale(LC_ALL, NULL);
+    setlocale(LC_ALL, locale);

[Paweł Hajdan Jr., 2011/06/09 08:43:22]

Please check the return value. NULL would indicate failure.

+  }

[Paweł Hajdan Jr., 2011/06/09 08:43:22]

nit: Add empty line below.

+  ~ScopedSetLocale() {
+    setlocale(LC_ALL, old_locale_.c_str());
+  }
+
+ private:
+  std::string old_locale_;
+
+  DISALLOW_COPY_AND_ASSIGN(ScopedSetLocale);
+};
+
+#endif
+
+}  // namespace base
+
+#endif  // BASE_TEST_TEST_UTIL_H_