Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 7002014: GTK: Look up newer menu symbols with older GTK+ versions. (Closed)

Created:
9 years, 7 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin, Evan Stade
CC:
chromium-reviews
Visibility:
Public.

Description

GTK: Look up newer menu symbols with older GTK+ versions. This conditionally compiles out the dlsym calls when built with newer GTKs. BUG=30213 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84887

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -14 lines) Patch
M chrome/browser/ui/gtk/global_bookmark_menu.cc View 5 chunks +38 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
Evan: continuing with a new patch. I think this will work until we start building ...
9 years, 7 months ago (2011-05-10 22:45:55 UTC) #1
Evan Martin
9 years, 7 months ago (2011-05-10 22:58:57 UTC) #2
LGTM, maybe at a TODO(erg) remove this once we have lucid everywhere

Powered by Google App Engine
This is Rietveld 408576698