Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 7002005: Use chromeos::CrosLibrary::Get()->EnsureLoaded() to replace chromeos::LoadLibcros() (Closed)

Created:
9 years, 7 months ago by Peng
Modified:
9 years, 5 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, Rick Byers
Visibility:
Public.

Description

Use chromeos::CrosLibrary::Get()->EnsureLoaded() to replace chromeos::LoadLibcros() BUG=crash on start with chromeos touchui TEST=manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84936

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/extensions/extension_input_ui_api.cc View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Peng
9 years, 7 months ago (2011-05-10 18:58:24 UTC) #1
bryeung
LGTM
9 years, 7 months ago (2011-05-10 18:59:42 UTC) #2
commit-bot: I haz the power
Try job failure for 7002005-1 on linux: http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux&number=25972
9 years, 7 months ago (2011-05-10 21:37:02 UTC) #3
commit-bot: I haz the power
9 years, 7 months ago (2011-05-11 05:52:00 UTC) #4
Change committed as 84936

Powered by Google App Engine
This is Rietveld 408576698