Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 7001025: Remove support for branch hints from the IA32 and X64 assembler. (Closed)

Created:
9 years, 7 months ago by fschneider
Modified:
9 years, 6 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Remove support for branch hints from the IA32 and X64 assembler. They were not on by default and should not be needed on modern platforms. Committed: http://code.google.com/p/v8/source/detail?r=7866

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -280 lines) Patch
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/assembler-ia32.h View 2 chunks +2 lines, -23 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 44 chunks +58 lines, -58 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/ic-ia32.cc View 25 chunks +41 lines, -41 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 13 chunks +19 lines, -19 lines 0 comments Download
M src/ia32/regexp-macro-assembler-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/regexp-macro-assembler-ia32.cc View 6 chunks +8 lines, -9 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 47 chunks +69 lines, -69 lines 0 comments Download
M src/x64/assembler-x64.h View 2 chunks +0 lines, -20 lines 0 comments Download
M src/x64/assembler-x64.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-assembler-ia32.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
9 years, 7 months ago (2011-05-11 13:03:19 UTC) #1
William Hesse
9 years, 7 months ago (2011-05-11 13:08:37 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698