More Quota WebSQLDatabase integration.

More Quota + WebSQLDatabase integration.

* Notify the QuotaManager of accesses and modifications to the amount of storage utlized.

* Still, the hard-coded 5MB limit is in place.

BUG=61676
TEST=database_tracker_unittest.cc, database_connections_unittest.cc
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85400

[michaeln, 2011-05-11 00:47:37]

I still want to write some tracker tests, but i think this should cover
notifying the QM (in deltas) as things change.

I had to carve out a place to keep the 'old' file size around size the actual
writes happen in the child processes and the main process just get told about
them after the fact. That's what the changes to DatabaseConnections are about,
providing a non-volatile place to keep the old file sizes for files that are
opened. The CacheOriginInfos can get blown away at any time, but the Connections
collection is safe from that.

[kinuko, 2011-05-11 11:43:27]

On 2011/05/11 00:47:37, michaeln wrote:
> I still want to write some tracker tests, but i think this should cover
> notifying the QM (in deltas) as things change.
> 
> I had to carve out a place to keep the 'old' file size around size the actual
> writes happen in the child processes and the main process just get told about
> them after the fact. That's what the changes to DatabaseConnections are about,
> providing a non-volatile place to keep the old file sizes for files that are
> opened. The CacheOriginInfos can get blown away at any time, but the
Connections
> collection is safe from that.

looking good, thanks for looking into this deep...
btw if we add another method that allow clients to notify 'new size' of the
quota instead of delta would that be helpful?

[michaeln, 2011-05-11 20:03:09]

Before adding new tests to the tracker, i'd like to make the QMProxy more
amendable to testing... virtualizing the thing so it's easier to see what's
being called.

How about I do that and add the methods that we've discussed going in that
direction while i'm at it and then revisit this CL.

void NotifyOriginNoLongerInUse(...)
void NotifyOriginInUse(...)
void NotifyStorageAccessed(...)

About delta vs absolute... the delta was easy enough to come up with... if we
want to revisit later we always can.

[kinuko, 2011-05-11 20:12:53]

On Thu, May 12, 2011 at 5:03 AM, <michaeln@chromium.org> wrote:

> Before adding new tests to the tracker, i'd like to make the QMProxy more
> amendable to testing... virtualizing the thing so it's easier to see what's
> being called.
>
> How about I do that and add the methods that we've discussed going in that
> direction while i'm at it and then revisit this CL.
>

sgtm.  I'm right now working on other parts (QM-FS integration
refactoring/bug fix) so I won't touch QM today/tomorrow.


> void NotifyOriginNoLongerInUse(...)
> void NotifyOriginInUse(...)
> void NotifyStorageAccessed(...)
>

About delta vs absolute... the delta was easy enough to come up with... if
> we
> want to revisit later we always can.
>
>
>
> http://codereview.chromium.org/7001014/
>

[michaeln, 2011-05-13 20:23:42]

added tests, please take a look

[kinuko, 2011-05-14 15:11:17]

LGTM

http://codereview.chromium.org/7001014/diff/8010/webkit/database/database_tra...
File webkit/database/database_tracker_unittest.cc (right):

http://codereview.chromium.org/7001014/diff/8010/webkit/database/database_tra...
webkit/database/database_tracker_unittest.cc:93: class TestQuotaManagerProxy :
public quota::QuotaManagerProxy {
Nicely done, we may want to share this class at some point.

http://codereview.chromium.org/7001014/diff/8010/webkit/database/database_tra...
webkit/database/database_tracker_unittest.cc:100: ~TestQuotaManagerProxy() {
virtual?

[michaeln, 2011-05-14 22:51:34]

Also added to the tests and fixed a bug found when doing so.

http://codereview.chromium.org/7001014/diff/8010/webkit/database/database_tra...
File webkit/database/database_tracker_unittest.cc (right):

http://codereview.chromium.org/7001014/diff/8010/webkit/database/database_tra...
webkit/database/database_tracker_unittest.cc:100: ~TestQuotaManagerProxy() {
On 2011/05/14 15:11:17, kinuko wrote:
> virtual?

Done.