Issue 70001: Force c++ dtors to get called in objc interfaces (it was always on since gcc4...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 70001: Force c++ dtors to get called in objc interfaces (it was always on since gcc4... (Closed)

Created:
11 years, 8 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Force c++ dtors to get called in objc interfaces (it was always on since gcc4.2, but this makes it explicit). Use scoped_* goodness. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13504

Patch Set 1 #

Total comments: 1

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -25 lines)			Patch
M	build/common.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/cocoa/browser_window_controller.h	View	2 chunks	+10 lines, -6 lines	0 comments	Download
M	chrome/browser/cocoa/browser_window_controller.mm	View	4 chunks	+14 lines, -19 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

11 years, 8 months ago (2009-04-10 15:23:29 UTC) #2

LGTM with or without this change.

http://codereview.chromium.org/70001/diff/1/4
File chrome/browser/cocoa/browser_window_controller.mm (right):

http://codereview.chromium.org/70001/diff/1/4#newcode31
Line 31: DCHECK(browser_.get());
Eliminate a .get() if you DCHCEK on browser instead of the _ version (probably
before doing the reset).

Expand Messages | Collapse Messages