Support symbol comparison in crankshaft.

Support symbol comparison in crankshaft.

Committed: http://code.google.com/p/v8/source/detail?r=7865

[Mads Ager (chromium), 2011-05-11 12:37:31]

http://codereview.chromium.org/7000021/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

http://codereview.chromium.org/7000021/diff/1/src/hydrogen-instructions.h#new...
src/hydrogen-instructions.h:2438: virtual bool DataEquals(HValue* other) {
return true; }
Don't you have to check that the ops are the same here? If the op is not used in
the check you should remove it from the instruction. If it is used you should
only GVN if the op is the same.

http://codereview.chromium.org/7000021/diff/1/src/hydrogen.h
File src/hydrogen.h (right):

http://codereview.chromium.org/7000021/diff/1/src/hydrogen.h#newcode875
src/hydrogen.h:875: HValue* right,
off-by-one indentation

[Vitaly Repeshko, 2011-05-11 12:44:46]

http://codereview.chromium.org/7000021/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

http://codereview.chromium.org/7000021/diff/1/src/hydrogen-instructions.h#new...
src/hydrogen-instructions.h:2438: virtual bool DataEquals(HValue* other) {
return true; }
On 2011/05/11 12:37:31, Mads Ager wrote:
> Don't you have to check that the ops are the same here? If the op is not used
in
> the check you should remove it from the instruction. If it is used you should
> only GVN if the op is the same.

Good catch! Fixed.

http://codereview.chromium.org/7000021/diff/1/src/hydrogen.h
File src/hydrogen.h (right):

http://codereview.chromium.org/7000021/diff/1/src/hydrogen.h#newcode875
src/hydrogen.h:875: HValue* right,
On 2011/05/11 12:37:31, Mads Ager wrote:
> off-by-one indentation

Fixed.

[Mads Ager (chromium), 2011-05-11 12:45:00]

LGTM