Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: chrome/chrome_exe.gypi

Issue 7000015: Temporarily add a disable_pie GYP flag (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added periods to comments. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_exe.gypi
diff --git a/chrome/chrome_exe.gypi b/chrome/chrome_exe.gypi
index 3089092898f837bbe702e90c18acd270d65eca67..ee25f1d090658028ed42c5bb0862748cdac29523 100644
--- a/chrome/chrome_exe.gypi
+++ b/chrome/chrome_exe.gypi
@@ -202,6 +202,13 @@
],
},
],
+ # TODO(rkc): Remove this once we have a fix for remote gdb
+ # and are able to correctly get section header offsets for
+ # pie executables. Currently -pie breaks remote debugging.
+ [ '(disable_pie==1 and chromeos==1)', {
+ 'ldflags' : ['-nopie'],
+ }
+ ],
['use_system_xdg_utils==0', {
'copies': [
{
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698