Temporarily add a disable_pie GYP flag

Temporarily add a disable_pie GYP flag
Add a flag that will disable building Chrome as a Position Independent Executable.


R=zelidrag@chromium.org,raymes@chromium.org
BUG=chromium-os:15161
TEST=Tested building with and without the flag; with the flag, symbols appear correctly in the remote session.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84892

[raymes, 2011-05-10 22:44:43]

http://codereview.chromium.org/7000015/diff/1/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/7000015/diff/1/build/common.gypi#newcode142
build/common.gypi:142: # Allow a user to link Chromium as a non-position
independent executable
Missing period

http://codereview.chromium.org/7000015/diff/1/chrome/chrome_exe.gypi
File chrome/chrome_exe.gypi (right):

http://codereview.chromium.org/7000015/diff/1/chrome/chrome_exe.gypi#newcode207
chrome/chrome_exe.gypi:207: # pie executables. Currently -pie breaks remote
debugging
Missing period.

http://codereview.chromium.org/7000015/diff/1/chrome/chrome_exe.gypi#newcode210
chrome/chrome_exe.gypi:210: }
This is only active if you set GYP_DEFINES="disable_pie=1", correct?

[rkc, 2011-05-10 22:48:38]

http://codereview.chromium.org/7000015/diff/1/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/7000015/diff/1/build/common.gypi#newcode142
build/common.gypi:142: # Allow a user to link Chromium as a non-position
independent executable
On 2011/05/10 22:44:43, raymes wrote:
> Missing period

Done.

http://codereview.chromium.org/7000015/diff/1/chrome/chrome_exe.gypi
File chrome/chrome_exe.gypi (right):

http://codereview.chromium.org/7000015/diff/1/chrome/chrome_exe.gypi#newcode207
chrome/chrome_exe.gypi:207: # pie executables. Currently -pie breaks remote
debugging
On 2011/05/10 22:44:43, raymes wrote:
> Missing period.

Done.

http://codereview.chromium.org/7000015/diff/1/chrome/chrome_exe.gypi#newcode210
chrome/chrome_exe.gypi:210: }
On 2011/05/10 22:44:43, raymes wrote:
> This is only active if you set GYP_DEFINES="disable_pie=1", correct?

Yes; or if it's added to the EXTRA_BUILD_ARGS when emerging chromeos-chrome

[raymes, 2011-05-10 22:49:37]

LGTM

On Tue, May 10, 2011 at 3:48 PM,  <rkc@chromium.org> wrote:
>
> http://codereview.chromium.org/7000015/diff/1/build/common.gypi
> File build/common.gypi (right):
>
> http://codereview.chromium.org/7000015/diff/1/build/common.gypi#newcode142
> build/common.gypi:142: # Allow a user to link Chromium as a non-position
> independent executable
> On 2011/05/10 22:44:43, raymes wrote:
>>
>> Missing period
>
> Done.
>
> http://codereview.chromium.org/7000015/diff/1/chrome/chrome_exe.gypi
> File chrome/chrome_exe.gypi (right):
>
>
http://codereview.chromium.org/7000015/diff/1/chrome/chrome_exe.gypi#newcode207
> chrome/chrome_exe.gypi:207: # pie executables. Currently -pie breaks
> remote debugging
> On 2011/05/10 22:44:43, raymes wrote:
>>
>> Missing period.
>
> Done.
>
>
http://codereview.chromium.org/7000015/diff/1/chrome/chrome_exe.gypi#newcode210
> chrome/chrome_exe.gypi:210: }
> On 2011/05/10 22:44:43, raymes wrote:
>>
>> This is only active if you set GYP_DEFINES="disable_pie=1", correct?
>
> Yes; or if it's added to the EXTRA_BUILD_ARGS when emerging
> chromeos-chrome
>
> http://codereview.chromium.org/7000015/
>

[zel, 2011-05-10 22:57:16]

LGTM

[Evan Martin, 2011-05-11 21:21:26]

Hey,
Can you CC me on further changes in this area?  It looks like you're making
ChromeOS-specific PIE changes -- why aren't you fixing all Linux?

[rkc, 2011-05-11 22:17:04]

Sure; and the reason we aren't doing this for the rest of Linux is because I
wasn't aware of any need for it.
This only affects remote gdb; regular gdb works just fine with the PIE
executable.

On Wed, May 11, 2011 at 14:21, <evan@chromium.org> wrote:

> Hey,
> Can you CC me on further changes in this area?  It looks like you're making
> ChromeOS-specific PIE changes -- why aren't you fixing all Linux?
>
>
> http://codereview.chromium.org/7000015/
>

[Evan Martin, 2011-05-11 22:35:26]

On 2011/05/11 22:17:04, Rahul Chaturvedi wrote:
> Sure; and the reason we aren't doing this for the rest of Linux is because I
> wasn't aware of any need for it.
> This only affects remote gdb; regular gdb works just fine with the PIE
> executable.

Ah, I see, it's only *disabling* pic.

How do you turn on PIE for chromeos?  I don't see any mention of it in the build
files...

[zel, 2011-05-11 22:48:09]

+wad
-chromium-reviews

Will can answer that one.

On Wed, May 11, 2011 at 3:35 PM, <evan@chromium.org> wrote:

> On 2011/05/11 22:17:04, Rahul Chaturvedi wrote:
>
>> Sure; and the reason we aren't doing this for the rest of Linux is because
>> I
>> wasn't aware of any need for it.
>> This only affects remote gdb; regular gdb works just fine with the PIE
>> executable.
>>
>
> Ah, I see, it's only *disabling* pic.
>
> How do you turn on PIE for chromeos?  I don't see any mention of it in the
> build
> files...
>
>
> http://codereview.chromium.org/7000015/
>

[raymes, 2011-05-11 22:48:49]

> How do you turn on PIE for chromeos?  I don't see any mention of it in the
> build
It's enabled by default in the compiler specs.


On Wed, May 11, 2011 at 3:48 PM, Zelidrag Hornung <zelidrag@chromium.org> wrote:
> +wad
> -chromium-reviews
>
> Will can answer that one.
> On Wed, May 11, 2011 at 3:35 PM, <evan@chromium.org> wrote:
>>
>> On 2011/05/11 22:17:04, Rahul Chaturvedi wrote:
>>>
>>> Sure; and the reason we aren't doing this for the rest of Linux is
>>> because I
>>> wasn't aware of any need for it.
>>> This only affects remote gdb; regular gdb works just fine with the PIE
>>> executable.
>>
>> Ah, I see, it's only *disabling* pic.
>>
>> How do you turn on PIE for chromeos?  I don't see any mention of it in the
>> build
>> files...
>>
>> http://codereview.chromium.org/7000015/
>
>

[rkc, 2011-05-11 23:18:54]

With a revision some time ago it was turned on - to take full advantage of
ASLR, PIE should always be on.
This is only for debugging purposes.

On Wed, May 11, 2011 at 15:48, Raymes Khoury <raymes@chromium.org> wrote:

> > How do you turn on PIE for chromeos?  I don't see any mention of it in
> the
> > build
> It's enabled by default in the compiler specs.
>
>
> On Wed, May 11, 2011 at 3:48 PM, Zelidrag Hornung <zelidrag@chromium.org>
> wrote:
> > +wad
> > -chromium-reviews
> >
> > Will can answer that one.
> > On Wed, May 11, 2011 at 3:35 PM, <evan@chromium.org> wrote:
> >>
> >> On 2011/05/11 22:17:04, Rahul Chaturvedi wrote:
> >>>
> >>> Sure; and the reason we aren't doing this for the rest of Linux is
> >>> because I
> >>> wasn't aware of any need for it.
> >>> This only affects remote gdb; regular gdb works just fine with the PIE
> >>> executable.
> >>
> >> Ah, I see, it's only *disabling* pic.
> >>
> >> How do you turn on PIE for chromeos?  I don't see any mention of it in
> the
> >> build
> >> files...
> >>
> >> http://codereview.chromium.org/7000015/
> >
> >
>