Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Side by Side Diff: Source/WebCore/rendering/RenderBlock.h

Issue 6999012: Merge 86160 - Fix null ptr crash from r85876 (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/742/
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 523 matching lines...) Expand 10 before | Expand all | Expand 10 after
534 534
535 // Called from lineWidth, to position the floats added in the last line. 535 // Called from lineWidth, to position the floats added in the last line.
536 // Returns true if and only if it has positioned any floats. 536 // Returns true if and only if it has positioned any floats.
537 bool positionNewFloats(); 537 bool positionNewFloats();
538 538
539 void clearFloats(); 539 void clearFloats();
540 int getClearDelta(RenderBox* child, int yPos); 540 int getClearDelta(RenderBox* child, int yPos);
541 541
542 virtual bool avoidsFloats() const; 542 virtual bool avoidsFloats() const;
543 543
544 bool hasOverhangingFloats() { return parent() && !hasColumns() && lowestFloa tLogicalBottom() > logicalHeight(); } 544 bool hasOverhangingFloats() { return parent() && !hasColumns() && containsFl oats() && lowestFloatLogicalBottom() > logicalHeight(); }
545 void addIntrudingFloats(RenderBlock* prev, int xoffset, int yoffset); 545 void addIntrudingFloats(RenderBlock* prev, int xoffset, int yoffset);
546 int addOverhangingFloats(RenderBlock* child, int xoffset, int yoffset, bool makeChildPaintOtherFloats); 546 int addOverhangingFloats(RenderBlock* child, int xoffset, int yoffset, bool makeChildPaintOtherFloats);
547 547
548 int lowestFloatLogicalBottom(FloatingObject::Type = FloatingObject::FloatBot h) const; 548 int lowestFloatLogicalBottom(FloatingObject::Type = FloatingObject::FloatBot h) const;
549 int nextFloatLogicalBottomBelow(int) const; 549 int nextFloatLogicalBottomBelow(int) const;
550 550
551 virtual bool hitTestColumns(const HitTestRequest&, HitTestResult&, int x, in t y, int tx, int ty, HitTestAction); 551 virtual bool hitTestColumns(const HitTestRequest&, HitTestResult&, int x, in t y, int tx, int ty, HitTestAction);
552 virtual bool hitTestContents(const HitTestRequest&, HitTestResult&, int x, i nt y, int tx, int ty, HitTestAction); 552 virtual bool hitTestContents(const HitTestRequest&, HitTestResult&, int x, i nt y, int tx, int ty, HitTestAction);
553 bool hitTestFloats(const HitTestRequest&, HitTestResult&, int x, int y, int tx, int ty); 553 bool hitTestFloats(const HitTestRequest&, HitTestResult&, int x, int y, int tx, int ty);
554 554
(...skipping 253 matching lines...) Expand 10 before | Expand all | Expand 10 after
808 ASSERT(!object || object->isRenderBlock()); 808 ASSERT(!object || object->isRenderBlock());
809 return static_cast<const RenderBlock*>(object); 809 return static_cast<const RenderBlock*>(object);
810 } 810 }
811 811
812 // This will catch anyone doing an unnecessary cast. 812 // This will catch anyone doing an unnecessary cast.
813 void toRenderBlock(const RenderBlock*); 813 void toRenderBlock(const RenderBlock*);
814 814
815 } // namespace WebCore 815 } // namespace WebCore
816 816
817 #endif // RenderBlock_h 817 #endif // RenderBlock_h
OLDNEW
« no previous file with comments | « LayoutTests/fast/block/float/no-overhanging-float-crash-expected.txt ('k') | Source/WebCore/rendering/RenderBlock.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698