Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 6997015: Limit the generation of regexp code with large inlined constants. (Closed)

Created:
9 years, 7 months ago by Erik Corry
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Limit the generation of regexp code with large inlined constants. Committed: http://code.google.com/p/v8/source/detail?r=7845

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -21 lines) Patch
M src/arm/regexp-macro-assembler-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/regexp-macro-assembler-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/ia32/regexp-macro-assembler-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/regexp-macro-assembler-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/jsregexp.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/jsregexp.cc View 2 chunks +15 lines, -1 line 0 comments Download
M src/mips/regexp-macro-assembler-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/regexp-macro-assembler-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/regexp-macro-assembler.h View 2 chunks +8 lines, -1 line 0 comments Download
M src/regexp-macro-assembler.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M src/regexp-macro-assembler-irregexp.h View 1 chunk +1 line, -1 line 0 comments Download
M src/regexp-macro-assembler-irregexp.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/regexp-macro-assembler-tracer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/regexp-macro-assembler-tracer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/regexp-macro-assembler-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/regexp-macro-assembler-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
9 years, 7 months ago (2011-05-10 13:15:48 UTC) #1
Søren Thygesen Gjesse
9 years, 7 months ago (2011-05-10 13:27:22 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698