Issue 6997007: Disable textfield's context menu in screen locker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6997007: Disable textfield's context menu in screen locker (Closed)

Created:
9 years, 7 months ago by oshima

Modified:
9 years, 6 months ago

Reviewers:
Daniel Erat, zel

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Disable context menu in screen locker Don't show image behind screen locker. BUG=chromium-os:14985, chromium-os:13154 TEST=lock the screen, and alt-click or right click passworld field. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84904

Patch Set 3 : " #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -7 lines)			Patch
	M	chrome/browser/chromeos/login/screen_lock_view.cc	View	1 2	3 chunks	+31 lines, -1 line	0 comments	Download
	M	chrome/browser/chromeos/login/screen_locker.cc	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

oshima

http://codereview.chromium.org/6997007/diff/2001/chrome/browser/chromeos/login/screen_locker.cc File chrome/browser/chromeos/login/screen_locker.cc (left): http://codereview.chromium.org/6997007/diff/2001/chrome/browser/chromeos/login/screen_locker.cc#oldcode814 chrome/browser/chromeos/login/screen_locker.cc:814: NULL, false); hmm, i wonder why I had two...

9 years, 7 months ago (2011-05-10 23:54:25 UTC) #1

Daniel Erat

LGTM http://codereview.chromium.org/6997007/diff/2001/chrome/browser/chromeos/login/screen_lock_view.cc File chrome/browser/chromeos/login/screen_lock_view.cc (right): http://codereview.chromium.org/6997007/diff/2001/chrome/browser/chromeos/login/screen_lock_view.cc#newcode27 chrome/browser/chromeos/login/screen_lock_view.cc:27: #include "views/controls/textfield/native_textfield_wrapper.h" nit: move this up one line

9 years, 7 months ago (2011-05-11 00:02:46 UTC) #2

LGTM

approved for merge into 742

Expand Messages | Collapse Messages

Issue 6997007: Disable textfield's context menu in screen locker (Closed)

Description

Patch Set 1 #

Patch Set 2 : " #

Patch Set 3 : " #

Messages