iwyu: Include stringprintf.h where appropriate, part 1.

base/json/string_escape.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/json/string_escape.h"
 
 #include <string>
 
+#include "base/stringprintf.h"
 #include "base/string_util.h"
 
 namespace base {
 
 namespace {
 
 // Try to escape |c| as a "SingleEscapeCharacter" (\n, etc).  If successful,
 // returns true and appends the escape sequence to |dst|.  This isn't required
 // by the spec, but it's more readable by humans than the \uXXXX alternatives.
 template<typename CHAR>
@@ skipping 37 matching lines @@
     dst->push_back('"');
 
   for (typename STR::const_iterator it = str.begin(); it != str.end(); ++it) {
     typename ToUnsigned<typename STR::value_type>::Unsigned c = *it;
     if (!JsonSingleEscapeChar(c, dst)) {
       if (c < 32 || c > 126 || c == '<' || c == '>') {
         // 1. Escaping <, > to prevent script execution.
         // 2. Technically, we could also pass through c > 126 as UTF8, but this
         //    is also optional.  It would also be a pain to implement here.
         unsigned int as_uint = static_cast<unsigned int>(c);
-        StringAppendF(dst, "\\u%04X", as_uint);
+        base::StringAppendF(dst, "\\u%04X", as_uint);

[Nico, 2011/05/10 02:57:51]

hm, these are not necessary because of ADL. does iwyu add these? do we prefer
explicitness over adl? it's a bit less flexible.

[James Hawkins, 2011/05/10 04:01:43]

No, I added them.  I prefer them, but I don't think the style guide says
anything about this. My rationale is that the style guide bans the use of using
entire namespaces (specifically because of ambiguity), and in my mind relyingon
ADL to get this right is even worse than using namespace base at the top of the
file.

       } else {
         unsigned char ascii = static_cast<unsigned char>(*it);
         dst->push_back(ascii);
       }
     }
   }
 
   if (put_in_quotes)
     dst->push_back('"');
 }
@@ skipping 18 matching lines @@
   JsonDoubleQuoteT(str, put_in_quotes, dst);
 }
 
 std::string GetDoubleQuotedJson(const string16& str) {
   std::string dst;
   JsonDoubleQuote(str, true, &dst);
   return dst;
 }
 
 }  // namespace base