SConstruct - Issue 6995161: Extend gdb-jit support (OSX/locals+parameters/prettyprint)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: SConstruct

Issue 6995161: Extend gdb-jit support (OSX/locals+parameters/prettyprint) (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: Rebase. Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: SConstruct

diff --git a/SConstruct b/SConstruct

index a51e7c8efb7691634b01a740babb4e4fa65c3d22..95dfd9e506498c1a37e804cc1fa3bcd62e6458a3 100644

--- a/SConstruct

+++ b/SConstruct

@@ -1155,8 +1155,8 @@ def VerifyOptions(env):

return False

if env['os'] == 'win32' and env['library'] == 'shared' and env['prof'] == 'on':

Abort("Profiling on windows only supported for static library.")

- if env['gdbjit'] == 'on' and (env['os'] != 'linux' or (env['arch'] != 'ia32' and env['arch'] != 'x64' and env['arch'] != 'arm')):

- Abort("GDBJIT interface is supported only for Intel-compatible (ia32 or x64) Linux target.")

+ if env['gdbjit'] == 'on' and ((env['os'] != 'linux' and env['os'] != 'macos') or (env['arch'] != 'ia32' and env['arch'] != 'x64' and env['arch'] != 'arm')):

+ Abort("GDBJIT interface is supported only for Intel-compatible (ia32 or x64) Linux/OSX target.")

if env['os'] == 'win32' and env['soname'] == 'on':

Abort("Shared Object soname not applicable for Windows.")

if env['soname'] == 'on' and env['library'] == 'static':

« no previous file with comments | « no previous file | src/compiler.cc » ('j') | src/gdb-jit.cc » ('J')