Issue 6995157: Disables tooltips if we can't create the tooltip window. I still don't

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6995157: Disables tooltips if we can't create the tooltip window. I still don't (Closed)

Created:
9 years, 6 months ago by sky

Modified:
9 years, 6 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, dhollowa, Glen Murphy

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Disables tooltips if we can't create the tooltip window. I still don't understand why we can't create tooltips for some folks, but this should at least keep us from crashing. BUG=82193 TEST=none R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88897

Patch Set 1 #

Patch Set 2 : Merge to trunk and update comments #

Total comments: 2

Patch Set 3 : Improved comments #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -52 lines)			Patch
M	ui/base/win/hwnd_util.cc	View		1 chunk	+2 lines, -16 lines	0 comments	Download
M	views/view.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	views/widget/aero_tooltip_manager.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	views/widget/aero_tooltip_manager.cc	View		1 chunk	+0 lines, -26 lines	0 comments	Download
M	views/widget/native_widget_win.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	views/widget/native_widget_win.cc	View	1 2	2 chunks	+8 lines, -1 line	0 comments	Download
M	views/widget/tooltip_manager_win.h	View	1	2 chunks	+5 lines, -2 lines	0 comments	Download
M	views/widget/tooltip_manager_win.cc	View		4 chunks	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

I'm also removing some code in AeroTooltipManager that was never executed (Init was previously invoked ...

9 years, 6 months ago (2011-06-13 17:12:04 UTC) #1

Ben Goodger (Google)

9 years, 6 months ago (2011-06-13 17:26:17 UTC) #2

LGTM

http://codereview.chromium.org/6995157/diff/2001/views/view.cc
File views/view.cc (right):

http://codereview.chromium.org/6995157/diff/2001/views/view.cc#newcode1244
views/view.cc:1244: if (widget && widget->native_widget()->GetTooltipManager())
Again note the mystery, otherwise you might find this check gets removed
accidentally.

http://codereview.chromium.org/6995157/diff/2001/views/widget/native_widget_w...
File views/widget/native_widget_win.cc (right):

http://codereview.chromium.org/6995157/diff/2001/views/widget/native_widget_w...
views/widget/native_widget_win.cc:1165: if (!tooltip_manager_->Init()) {
You might note the mystery of why this check exists, even if you have no
explanation.

Expand Messages | Collapse Messages