bisect-builds.py: Use Google Common Data Storage instead of build.chromium.org.

bisect-builds.py: Use Google Common Data Storage instead of build.chromium.org.

The continuous archive's index file appears to be incomplete/problematic for
some platforms and revision ranges, so go back to just using directory lists
via the CDS API.

This also cleans up the code by using a PathContext object rather than a slew of
global variables to format/create the various URLs.

BUG=85498
TEST=See bug.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88658

[Evan Martin, 2011-06-09 20:26:11]

Can you get whoever is responsible for our use of this CDS API to review this?

[Robert Sesek, 2011-06-09 20:26:54]

On 2011/06/09 20:26:11, Evan Martin wrote:
> Can you get whoever is responsible for our use of this CDS API to review this?

Sure. +nsylvain

[nsylvain, 2011-06-09 21:12:02]

pretty cool! thanks! 

1 comment.

http://codereview.chromium.org/6995117/diff/1/tools/bisect-builds.py
File tools/bisect-builds.py (right):

http://codereview.chromium.org/6995117/diff/1/tools/bisect-builds.py#newcode172
tools/bisect-builds.py:172: context.GetListingURL(context.good_revision))
I'm not sure this works well.  I don't think the output is guaranteed to be
sorted by revision, so using the marker as a starting point might not work well.
 I'd start from the beginning, build the list of revs, sort it, and then trim
everything prior to good_revision. (which you seem to be doing anyway later)
WDYT?

[Robert Sesek, 2011-06-09 23:38:58]

Thanks for the review.

http://codereview.chromium.org/6995117/diff/1/tools/bisect-builds.py
File tools/bisect-builds.py (right):

http://codereview.chromium.org/6995117/diff/1/tools/bisect-builds.py#newcode172
tools/bisect-builds.py:172: context.GetListingURL(context.good_revision))
On 2011/06/09 21:12:03, nsylvain wrote:
> I'm not sure this works well.  I don't think the output is guaranteed to be
> sorted by revision, so using the marker as a starting point might not work
well.
>  I'd start from the beginning, build the list of revs, sort it, and then trim
> everything prior to good_revision. (which you seem to be doing anyway later)
> WDYT?

Ah, thanks. I didn't realize that; was just trying to save a few HTTP requests.
I guess it really doesn't matter much.

[nsylvain, 2011-06-09 23:50:31]

LGTM, thanks