Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 6995108: Correct the limit of local variables in a optimized functions. (Closed)

Created:
9 years, 6 months ago by Mads Ager (chromium)
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Correct the limit of local variables in a optimized functions. The encoding constraint is that we have 128 values. We use [-64,0] for parameters and [0,63] for locals. However, for locals we restricted to 64 and not 63. R=kmillikin@chromium.org TEST=mjsunit/compiler/regress-max-locals-for-osr.js Committed: http://code.google.com/p/v8/source/detail?r=8242

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -3 lines) Patch
M src/compiler.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +9 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/regress-max-locals-for-osr.js View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
9 years, 6 months ago (2011-06-09 13:26:15 UTC) #1
Kevin Millikin (Chromium)
9 years, 6 months ago (2011-06-09 14:41:45 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698