Issue 6995092: Enable client-side phishing detection for release builds.

Issue 6995092: Enable client-side phishing detection for release builds. (Closed)

Created:
9 years, 6 months ago by noelutz

Modified:
9 years, 6 months ago

Reviewers:
commit-bot: I haz the power, Brian Ryner, Garrett Casto, mattm

CC:
chromium-reviews

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Enable client-side phishing detection for stable builds. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88597

Patch Set 2 : Remove unnecessary include #

Total comments: 2

Patch Set 3 : Fix comment. #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -11 lines)			Patch
	M	chrome/browser/browser_process_impl.cc	View	1 2	2 chunks	+3 lines, -11 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Brian Ryner

LGTM nit: in the CL description, you might want to say "stable" rather than "release".

9 years, 6 months ago (2011-06-09 19:03:03 UTC) #2

mattm

lgtm with nit http://codereview.chromium.org/6995092/diff/2001/chrome/browser/browser_process_impl.cc File chrome/browser/browser_process_impl.cc (right): http://codereview.chromium.org/6995092/diff/2001/chrome/browser/browser_process_impl.cc#newcode1013 chrome/browser/browser_process_impl.cc:1013: // channel. Comment needs updating. Maybe ...

9 years, 6 months ago (2011-06-09 20:07:02 UTC) #3

noelutz

submitting now. Thanks, noé. http://codereview.chromium.org/6995092/diff/2001/chrome/browser/browser_process_impl.cc File chrome/browser/browser_process_impl.cc (right): http://codereview.chromium.org/6995092/diff/2001/chrome/browser/browser_process_impl.cc#newcode1013 chrome/browser/browser_process_impl.cc:1013: // channel. On 2011/06/09 20:07:02, ...

9 years, 6 months ago (2011-06-09 21:13:41 UTC) #4

Change committed as 88597

Expand Messages | Collapse Messages