content/renderer/render_view.cc - Issue 6995091: Avoid a NOT_REACHED() hit when we get an empty 404 page and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view.cc

Issue 6995091: Avoid a NOT_REACHED() hit when we get an empty 404 page and (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view.cc

diff --git a/content/renderer/render_view.cc b/content/renderer/render_view.cc

index 0d1e8e06135343697d8d0c522435b7a83ab9063f..742c58130439368b261181aa5c8754e201310fd8 100644

--- a/content/renderer/render_view.cc

+++ b/content/renderer/render_view.cc

@@ -2634,6 +2634,8 @@ void RenderView::didFinishResourceLoad(

const GURL& error_page_url = GetAlternateErrorPageURL(frame_url, HTTP_404);

if (error_page_url.is_valid()) {

WebURLError original_error;

+ original_error.domain = "http";

+ original_error.reason = 404;

original_error.unreachableURL = frame_url;

navigation_state->set_alt_error_page_fetcher(

« no previous file with comments | « no previous file | no next file » | no next file with comments »