Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 6995090: Mac: Disable loading 2x bitmaps on 10.5 and 10.6 (Closed)

Created:
9 years, 6 months ago by sail
Modified:
8 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Mac: Disable loading 2x bitmaps on 10.5 and 10.6 Loading 2x bitmaps on 10.5 caused a regression in our startup time. Since we don't need 2x bitmaps on 10.5 and 10.6 simple fix is to simply disable loading the bitmaps on those platforms. BUG=80501 TEST=Ran on 10.6 and used logs to verify that the resource pak was not being loaded. Did the same on 10.7 and verified that the resource pak was being loaded.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M ui/base/resource/resource_bundle_mac.mm View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
sail
9 years, 6 months ago (2011-06-08 21:20:59 UTC) #1
Robert Sesek
LGTM
9 years, 6 months ago (2011-06-08 21:43:29 UTC) #2
commit-bot: I haz the power
Change committed as 88426
9 years, 6 months ago (2011-06-08 22:36:43 UTC) #3
Mark Mentovai
LGTM-post-facto
9 years, 6 months ago (2011-06-09 14:30:50 UTC) #4
Nico
Err, what? We're happy with regressing 10.7 startup time just because we have no bot ...
8 years, 6 months ago (2012-06-18 15:27:50 UTC) #5
sail
On 2012/06/18 15:27:50, Nico wrote: > Err, what? We're happy with regressing 10.7 startup time ...
8 years, 6 months ago (2012-06-18 19:32:46 UTC) #6
Nico
8 years, 6 months ago (2012-06-18 19:59:32 UTC) #7
On 2012/06/18 19:32:46, sail wrote:
> On 2012/06/18 15:27:50, Nico wrote:
> > Err, what? We're happy with regressing 10.7 startup time just because we
have
> no
> > bot which measures that?
> 
> I'm not sure what a good fix for this is. One solution would be to stop using
> resource packs on Mac and load individual images. This way we can avoid
loading
> / decoding the full image until necessary.

Yes, NSImage can do lazy loading of reps. We should probably have something like
that.

Powered by Google App Engine
This is Rietveld 408576698