Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: net/base/dns_response.h

Issue 6995088: Break the dependency of DnsQuery and DnsResponse from AddressList (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More comment fixes. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/dns_query_unittest.cc ('k') | net/base/dns_response.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/dns_response.h
diff --git a/net/base/dns_response.h b/net/base/dns_response.h
index 39ee47d5f9343cc89d3fb38c6c1a02b618d9d2e9..b0704c95f6246da18a2c128df25a6d59da51579d 100644
--- a/net/base/dns_response.h
+++ b/net/base/dns_response.h
@@ -10,10 +10,8 @@
namespace net{
-class AddressList;
-
-// A class that encapsulates bits and pieces related to DNS response
-// processing.
+// Represents on-the-wire DNS response as an object; allows extracting
+// records.
class DnsResponse {
public:
// Constructs an object with an IOBuffer large enough to read
@@ -27,9 +25,9 @@ class DnsResponse {
// read.
IOBufferWithSize* io_buffer() { return io_buffer_.get(); }
- // Parses response of size nbytes and puts address into |results|,
+ // Parses response of size nbytes and puts address into |ip_addresses|,
// returns net_error code in case of failure.
- int Parse(int nbytes, AddressList* results);
+ int Parse(int nbytes, std::vector<IPAddressNumber>* ip_addresses);
private:
// The matching query; |this| is the response for |query_|. We do not
« no previous file with comments | « net/base/dns_query_unittest.cc ('k') | net/base/dns_response.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698