Break the dependency of DnsQuery and DnsResponse from AddressList

net/base/dns_query_unittest.cc

Index: net/base/dns_query_unittest.cc
diff --git a/net/base/dns_query_unittest.cc b/net/base/dns_query_unittest.cc
index ba21c4e02353434e07581bc76341533167fc4961..412393e4d5b22a306544f68dcc92f7471b74dc16 100644
--- a/net/base/dns_query_unittest.cc
+++ b/net/base/dns_query_unittest.cc
@@ -42,35 +42,11 @@ namespace net {
 //  |                     QCLASS                    |
 //  +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
 
-TEST(DnsQueryTest, RandomIdTest) {
-  const std::string kHostname = "www.google.com";
-  const uint16 kPort = 80;
-
-  DnsQuery q1(kHostname, ADDRESS_FAMILY_IPV4, kPort);
-  EXPECT_TRUE(q1.IsValid());
-  EXPECT_EQ(kPort, q1.port());
-  EXPECT_EQ(kDNS_A, q1.qtype());
-  EXPECT_EQ(kHostname, q1.hostname());
-
-  DnsQuery q2(kHostname, ADDRESS_FAMILY_IPV4, kPort);
-  EXPECT_TRUE(q2.IsValid());
-  EXPECT_EQ(kPort, q2.port());
-  EXPECT_EQ(kDNS_A, q2.qtype());
-  EXPECT_EQ(kHostname, q2.hostname());
-
-  // This has a 1/2^16 probability of failure.
-  EXPECT_FALSE(q1.id() == q2.id());
-}
-
 TEST(DnsQueryTest, ConstructorTest) {
-  const std::string kHostname = "www.google.com";
-  const uint16 kPort = 80;
+  std::string kHostnameDns("\003www\006google\003com", 16);
 
-  DnsQuery q1(kHostname, ADDRESS_FAMILY_IPV4, kPort);
-  EXPECT_TRUE(q1.IsValid());
-  EXPECT_EQ(kPort, q1.port());
+  DnsQuery q1(kHostnameDns, kDNS_A);
   EXPECT_EQ(kDNS_A, q1.qtype());
-  EXPECT_EQ(kHostname, q1.hostname());
 
   uint8 id_hi = q1.id() >> 8, id_lo = q1.id() & 0xff;
 
@@ -96,14 +72,33 @@ TEST(DnsQueryTest, ConstructorTest) {
 
   int expected_size = arraysize(query_data);
   EXPECT_EQ(expected_size, q1.io_buffer()->size());
-  EXPECT_EQ(0, memcmp(q1.io_buffer()->data(), query_data,
-                      q1.io_buffer()->size()));
+  EXPECT_EQ(0, memcmp(q1.io_buffer()->data(), query_data, expected_size));
+}
+
+TEST(DnsQueryTest, CloneTest) {
+  std::string kHostnameDns("\003www\006google\003com", 16);
+
+  DnsQuery q1(kHostnameDns, kDNS_A);
+  scoped_ptr<DnsQuery> q2(q1.CloneWithNewId());
+  EXPECT_EQ(q1.io_buffer()->size(), q2->io_buffer()->size());
+  EXPECT_EQ(q1.qtype(), q2->qtype());
+  EXPECT_EQ(q1.question_size(), q2->question_size());
+  EXPECT_EQ(0, memcmp(q1.question_data(), q2->question_data(),
+                      q1.question_size()));
+}
 
-  // Query with a long hostname.
-  const char hostname_too_long[] = "123456789.123456789.123456789.123456789.123456789.123456789.123456789.123456789.123456789.123456789.123456789.123456789.123456789.123456789.123456789.123456789.123456789.123456789.123456789.123456789.123456789.123456789.123456789.123456789.123456789.1234";
+TEST(DnsQueryTest, RandomIdTest) {
+  std::string kHostnameDns("\003www\006google\003com", 16);
+
+  DnsQuery q1(kHostnameDns, kDNS_A);
+  DnsQuery q2(kHostnameDns, kDNS_A);
+
+  // Each of the following equality tests have a 1/2^16 probability of
+  // failure.
+  EXPECT_FALSE(q1.id() == q2.id());

[cbentzel, 2011/06/09 01:16:06]

I still don't like this test because it _will_ fail on some run. 

[agayev, 2011/06/09 14:23:02]

We don't have an API for setting a seed to get a deterministic behavior.  Should
I get rid of them?

How about generating queries in a loop of 100 times and breaking out first time
they are different?  Probability of generating same ids 100 times in a row is
virtually 0.

 
-  DnsQuery q2(hostname_too_long, ADDRESS_FAMILY_IPV4, kPort);
-  EXPECT_FALSE(q2.IsValid());
+  scoped_ptr<DnsQuery> q3(q1.CloneWithNewId());
+  EXPECT_FALSE(q1.id() == q3->id());
 }
 
 }  // namespace net