Issue 6995086: Update about:net-internals to use Javascript for loading logs.

Issue 6995086: Update about:net-internals to use Javascript for loading logs. (Closed)

Created:
9 years, 6 months ago by mmenke

Modified:
9 years, 6 months ago

Reviewers:
commit-bot: I haz the power, eroman

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Update about:net-internals to use Javascript for loading logs. BUG=none TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88460

Patch Set 2 : Fix variable names in response to comment #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -94 lines)			Patch
M	chrome/browser/resources/net_internals/dataview.js	View	1	2 chunks	+34 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/net_internals/index.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/net_internals/main.js	View	1	2 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/browser/ui/webui/net_internals_ui.cc	View	1	10 chunks	+2 lines, -86 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

mmenke

Not sure why this is working now. Regardless, simplifies things a bit.

9 years, 6 months ago (2011-06-08 20:46:23 UTC) #1

eroman

http://codereview.chromium.org/6995086/diff/1006/chrome/browser/resources/net_internals/dataview.js File chrome/browser/resources/net_internals/dataview.js (right): http://codereview.chromium.org/6995086/diff/1006/chrome/browser/resources/net_internals/dataview.js#newcode146 chrome/browser/resources/net_internals/dataview.js:146: var log_file = loadLogFileElement.files[0]; nit: useCamelCaseForVariableName. http://codereview.chromium.org/6995086/diff/1006/chrome/browser/resources/net_internals/dataview.js#newcode148 chrome/browser/resources/net_internals/dataview.js:148: var ...

9 years, 6 months ago (2011-06-08 23:25:25 UTC) #3

mmenke

Fixed. Thanks for catching that. On 2011/06/08 23:25:25, eroman wrote: > http://codereview.chromium.org/6995086/diff/1006/chrome/browser/resources/net_internals/dataview.js > File chrome/browser/resources/net_internals/dataview.js ...

9 years, 6 months ago (2011-06-08 23:46:44 UTC) #4

Change committed as 88460

Expand Messages | Collapse Messages