Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: ppapi/proxy/plugin_var_tracker_unittest.cc

Issue 6995083: Proxy PPB_Var, fix o-o-p string var id tracking. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updated resource tracker unit test Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/proxy/plugin_var_tracker_unittest.cc
diff --git a/ppapi/proxy/plugin_var_tracker_unittest.cc b/ppapi/proxy/plugin_var_tracker_unittest.cc
index 3f7e220651e726f384afc3c92624f970f5cd26ff..08fba9bc4baccb6b9c4a27912447313bd58db758 100644
--- a/ppapi/proxy/plugin_var_tracker_unittest.cc
+++ b/ppapi/proxy/plugin_var_tracker_unittest.cc
@@ -58,10 +58,11 @@ TEST_F(PluginVarTrackerTest, Strings) {
EXPECT_NE(0, str_id2);
// Make sure the strings come out the other end.
- std::string result = var_tracker().GetString(MakeString(str_id1));
- EXPECT_EQ(str, result);
- result = var_tracker().GetString(MakeString(str_id2));
- EXPECT_EQ(str, result);
+ const std::string* result =
+ var_tracker().GetExistingString(MakeString(str_id1));
+ EXPECT_EQ(str, *result);
+ result = var_tracker().GetExistingString(MakeString(str_id2));
+ EXPECT_EQ(str, *result);
}
TEST_F(PluginVarTrackerTest, GetHostObject) {

Powered by Google App Engine
This is Rietveld 408576698