Proxy PPB_Var, fix o-o-p string var id tracking.

ppapi/tests/test_var_deprecated.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/tests/test_var_deprecated.h"
 
 #include <string.h>
 
 #include <limits>
 
@@ skipping 88 matching lines @@
     ASSERT_EQ(PP_VARTYPE_STRING, str.type);
 
     // Reading back the string should work.
     uint32_t len = 0;
     const char* result = var_interface_->VarToUtf8(str, &len);
     ASSERT_EQ(kStrLen, len);
     ASSERT_EQ(0, strncmp(kStr, result, kStrLen));
 
     // Destroy the string, readback should now fail.
     var_interface_->Release(str);
-    /*
-    Note: this will crash in the current out-of-process implementation since
-    we don't do actual tracking of strings (we just convert the ID to a
-    pointer).
-    TODO(brettw) This should be fixed and this checking code re-enabled.
     result = var_interface_->VarToUtf8(str, &len);
     ASSERT_EQ(0, len);
     ASSERT_EQ(NULL, result);
-    */
   }
 
   // Make sure nothing leaked.
   ASSERT_TRUE(testing_interface_->GetLiveObjectsForInstance(
       instance_->pp_instance()) == before_object);
 
   PASS();
 }
 
 std::string TestVarDeprecated::TestInvalidAndEmpty() {
@@ skipping 267 matching lines @@
   // If the reference counting works, the object should be valid. We can test
   // this by executing it (it was a function we defined above) and it should
   // return "works" concatenated with the argument.
   pp::VarPrivate function(var_from_page_);
   pp::Var result = var_from_page_.Call(pp::Var(), "nice");
   ASSERT_TRUE(result.is_string());
   ASSERT_TRUE(result.AsString() == "worksnice");
 
   PASS();
 }