Fix a browser, renderer, plugin deadlock caused by the change to reparent plugin windows in the b...

content/browser/plugin_process_host.cc

Index: content/browser/plugin_process_host.cc
===================================================================
--- content/browser/plugin_process_host.cc	(revision 88161)
+++ content/browser/plugin_process_host.cc	(working copy)
@@ -72,12 +72,18 @@
     return;
 
   if (webkit::npapi::WebPluginDelegateImpl::IsDummyActivationWindow(window)) {
-    ::SetWindowLongPtr(window, GWL_STYLE, WS_CHILD);
+    BrowserThread::PostTask(
+        BrowserThread::UI, FROM_HERE,
+        NewRunnableFunction(::SetWindowLongPtr, window, GWL_STYLE, WS_CHILD));
   } else {
-    ::SetWindowLongPtr(window, GWL_STYLE, WS_CHILD | WS_CLIPCHILDREN |
-                       WS_CLIPSIBLINGS);
+    BrowserThread::PostTask(
+        BrowserThread::UI, FROM_HERE,
+        NewRunnableFunction(::SetWindowLongPtr, window, GWL_STYLE,
+                            WS_CHILD | WS_CLIPCHILDREN | WS_CLIPSIBLINGS));
   }
-  ::SetParent(window, parent);
+  BrowserThread::PostTask(
+      BrowserThread::UI, FROM_HERE,
+      NewRunnableFunction(::SetParent, window, parent));

[cpu_(ooo_6.6-7.5), 2011/06/08 18:04:31]

Is not easier to just make a single function that does all the 3 things and call
it via PostTask?

[ananta, 2011/06/08 18:10:47]

Done.

 }
 #endif  // defined(OS_WIN)