Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1149)

Issue 6995082: Fix a browser, renderer, plugin deadlock caused by the change to reparent plugin windows in the b... (Closed)

Created:
9 years, 6 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
cpu_(ooo_6.6-7.5), jam
CC:
chromium-reviews, joi+watch-content_chromium.org, jam
Visibility:
Public.

Description

Fix a browser, renderer, plugin deadlock caused by the change to reparent plugin windows in the browser process. Reparenting occurs via Windows API calls on the IO thread which can result in window messages being dispatched to plugin windows which may be blocked on outgoing sync calls. Fix is to execute the Windows API calls on the UI thread. Fixes bug http://code.google.com/p/chromium/issues/detail?id=85397 BUG=85397 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88393

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -7 lines) Patch
M content/browser/plugin_process_host.cc View 1 2 chunks +18 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ananta
9 years, 6 months ago (2011-06-08 17:42:58 UTC) #1
cpu_(ooo_6.6-7.5)
http://codereview.chromium.org/6995082/diff/1/content/browser/plugin_process_host.cc File content/browser/plugin_process_host.cc (right): http://codereview.chromium.org/6995082/diff/1/content/browser/plugin_process_host.cc#newcode86 content/browser/plugin_process_host.cc:86: NewRunnableFunction(::SetParent, window, parent)); Is not easier to just make ...
9 years, 6 months ago (2011-06-08 18:04:31 UTC) #2
ananta
http://codereview.chromium.org/6995082/diff/1/content/browser/plugin_process_host.cc File content/browser/plugin_process_host.cc (right): http://codereview.chromium.org/6995082/diff/1/content/browser/plugin_process_host.cc#newcode86 content/browser/plugin_process_host.cc:86: NewRunnableFunction(::SetParent, window, parent)); On 2011/06/08 18:04:31, cpu wrote: > ...
9 years, 6 months ago (2011-06-08 18:10:47 UTC) #3
cpu_(ooo_6.6-7.5)
9 years, 6 months ago (2011-06-08 19:55:38 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698