Change timeout for all ChromeDriver automation calls to infinite

In ChromeDriver, do not use timeouts for automation calls. WebDriver is a tool for general purpose testing, and has no notion of timeouts currently.
Many users were running into cases where they wanted a longer timeout than the current 25s.
BUG=82457
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88365

[Huyen, 2011-06-07 22:34:01]

Please take a look when you have a chance. Thanks!

[kkania, 2011-06-07 22:55:27]

http://codereview.chromium.org/6995060/diff/1/chrome/test/automation/automati...
File chrome/test/automation/automation_json_requests.cc (right):

http://codereview.chromium.org/6995060/diff/1/chrome/test/automation/automati...
chrome/test/automation/automation_json_requests.cc:1: // Copyright (c) 2011 The
Chromium Authors. All rights reserved.
overall stuff (I put it here because many people miss it if its in the overall
description):

-set BUG=82457
-let's move the base::kTimeoutMs from here to webdriver/automation.cc. Just make
all the Send*Request functions that need a custom timeout take an int timeout_ms
arg.

http://codereview.chromium.org/6995060/diff/1/chrome/test/automation/automati...
chrome/test/automation/automation_json_requests.cc:84: int timeout_ms =
TestTimeouts::action_max_timeout_ms();
make this one call sender->Send(msg) instead of sender->Send(msg, timeout); we
should have never used action_max_timeout_ms in this file.

http://codereview.chromium.org/6995060/diff/1/chrome/test/automation/automati...
chrome/test/automation/automation_json_requests.cc:338: if
(!SendAutomationJSONRequest(sender, dict, &reply_dict,
you can forget adding custom timeout to the deprecated requests in this file

http://codereview.chromium.org/6995060/diff/1/chrome/test/automation/automati...
chrome/test/automation/automation_json_requests.cc:612: if
(!SendAutomationJSONRequest(sender, dict, &reply_dict,
I don't think need custom timeout here

http://codereview.chromium.org/6995060/diff/1/chrome/test/automation/automati...
chrome/test/automation/automation_json_requests.cc:628: base::kNoTimeout,
error_msg);
or here

http://codereview.chromium.org/6995060/diff/1/chrome/test/automation/automati...
chrome/test/automation/automation_json_requests.cc:641: base::kNoTimeout,
error_msg);
or here

[kkania, 2011-06-08 00:54:53]

http://codereview.chromium.org/6995060/diff/3004/chrome/test/webdriver/automa...
File chrome/test/webdriver/automation.cc (right):

http://codereview.chromium.org/6995060/diff/3004/chrome/test/webdriver/automa...
chrome/test/webdriver/automation.cc:181: // set action_timeout_ms to infinite
remove

http://codereview.chromium.org/6995060/diff/3004/chrome/test/webdriver/automa...
File chrome/test/webdriver/automation.h (right):

http://codereview.chromium.org/6995060/diff/3004/chrome/test/webdriver/automa...
chrome/test/webdriver/automation.h:14: #include
"base/synchronization/waitable_event.h"
put in cc

[kkania, 2011-06-08 00:55:50]

LGTM, after you change CL description

[Huyen, 2011-06-08 00:59:34]

http://codereview.chromium.org/6995060/diff/3004/chrome/test/webdriver/automa...
File chrome/test/webdriver/automation.cc (right):

http://codereview.chromium.org/6995060/diff/3004/chrome/test/webdriver/automa...
chrome/test/webdriver/automation.cc:181: // set action_timeout_ms to infinite
On 2011/06/08 00:54:53, kkania wrote:
> remove

Done.

http://codereview.chromium.org/6995060/diff/3004/chrome/test/webdriver/automa...
File chrome/test/webdriver/automation.h (right):

http://codereview.chromium.org/6995060/diff/3004/chrome/test/webdriver/automa...
chrome/test/webdriver/automation.h:14: #include
"base/synchronization/waitable_event.h"
On 2011/06/08 00:54:53, kkania wrote:
> put in cc

Done.

[commit-bot: I haz the power, 2011-06-08 17:31:18]

Commit queue failed due to updated description.