Issue 6995046: Support %_IsUndetectableObject in crankshaft.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6995046: Support %_IsUndetectableObject in crankshaft. (Closed)

Created:
9 years, 7 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
fschneider

CC:
v8-dev

Visibility:
Public.

Description

Support %_IsUndetectableObject in crankshaft. Committed: http://code.google.com/p/v8/source/detail?r=7856

Patch Set 2 : Review fixes #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+308 lines, -10 lines)			Patch
M	src/arm/lithium-arm.h	View		3 chunks	+29 lines, -2 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View		3 chunks	+21 lines, -0 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View		1 chunk	+34 lines, -0 lines	0 comments	Download
M	src/hydrogen.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	src/hydrogen-instructions.h	View		2 chunks	+13 lines, -1 line	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1	1 chunk	+38 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View		2 chunks	+29 lines, -2 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View		3 chunks	+21 lines, -0 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View		1 chunk	+34 lines, -0 lines	0 comments	Download
M	src/x64/lithium-x64.h	View		4 chunks	+31 lines, -4 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View		3 chunks	+21 lines, -0 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1	1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

fschneider

LGTM with one comment. http://codereview.chromium.org/6995046/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): http://codereview.chromium.org/6995046/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode1721 src/ia32/lithium-codegen-ia32.cc:1721: __ mov(result, factory()->true_value()); This must ...

9 years, 7 months ago (2011-05-11 09:27:20 UTC) #2

Vitaly Repeshko

9 years, 7 months ago (2011-05-11 09:35:02 UTC) #3

http://codereview.chromium.org/6995046/diff/1/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):

http://codereview.chromium.org/6995046/diff/1/src/ia32/lithium-codegen-ia32.c...
src/ia32/lithium-codegen-ia32.cc:1721: __ mov(result, factory()->true_value());
On 2011/05/11 09:27:20, fschneider wrote:
> This must be false_value().

Whoops, fixed. This means we need a test for %_IsUndetectable used as boolean.
I'll add it.

Expand Messages | Collapse Messages

Issue 6995046: Support %_IsUndetectableObject in crankshaft. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Review fixes #

Messages