Issue 6995032: Fix a browser crash involving omnibox extension keywords.

Issue 6995032: Fix a browser crash involving omnibox extension keywords. (Closed)

Created:
9 years, 7 months ago by Matt Perry

Modified:
9 years, 7 months ago

Reviewers:
commit-bot: I haz the power, Peter Kasting

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix a browser crash involving omnibox extension keywords. The |match| sometimes did not have a valid template_url, because GetInfoForCurrentText was classifying the match using the wrong parameters. Fixed to use prefer_keyword==true in this case. BUG=81776 TEST=see bug for repro Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84921

Patch Set 1 #

Patch Set 2 : classify #

Total comments: 2

Patch Set 3 : linux.and.mac #

Patch Set 4 : latest #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -13 lines)			Patch
M	chrome/browser/autocomplete/autocomplete_classifier.h	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_classifier.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit.cc	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/autocomplete/search_provider.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/gtk_util.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/frame/browser_root_view.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

Need to change CL description. Then LGTM with fix below. http://codereview.chromium.org/6995032/diff/2001/chrome/browser/autocomplete/autocomplete_edit.cc File chrome/browser/autocomplete/autocomplete_edit.cc (right): http://codereview.chromium.org/6995032/diff/2001/chrome/browser/autocomplete/autocomplete_edit.cc#newcode415 ...

9 years, 7 months ago (2011-05-10 22:47:49 UTC) #3

Matt Perry

http://codereview.chromium.org/6995032/diff/2001/chrome/browser/autocomplete/autocomplete_edit.cc File chrome/browser/autocomplete/autocomplete_edit.cc (right): http://codereview.chromium.org/6995032/diff/2001/chrome/browser/autocomplete/autocomplete_edit.cc#newcode415 chrome/browser/autocomplete/autocomplete_edit.cc:415: KeywordIsSelected(), false, On 2011/05/10 22:47:49, Peter Kasting wrote: > ...

9 years, 7 months ago (2011-05-10 22:53:32 UTC) #4

Change committed as 84921

Expand Messages | Collapse Messages