Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 6995024: Improved c1visualizer output a bit: Emit a human-readable description for (Closed)

Created:
9 years, 7 months ago by Sven Panne
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Improved c1visualizer output a bit: Emit a human-readable description for changes instead of a bit-pattern. Fixed logic when ranges are emitted. Improved indentation in hydrogen.cfg (aesthetical change only). Some minor additional cleanup.

Patch Set 1 #

Total comments: 5

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -27 lines) Patch
M src/hydrogen.cc View 1 4 chunks +6 lines, -2 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M src/hydrogen-instructions.cc View 1 3 chunks +43 lines, -24 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sven Panne
9 years, 7 months ago (2011-05-10 14:51:26 UTC) #1
fschneider
LGTM. http://codereview.chromium.org/6995024/diff/1/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): http://codereview.chromium.org/6995024/diff/1/src/hydrogen-instructions.cc#newcode423 src/hydrogen-instructions.cc:423: stream->Add("EVERYTHING"); "*" would be less verbose. http://codereview.chromium.org/6995024/diff/1/src/hydrogen-instructions.cc#newcode426 src/hydrogen-instructions.cc:426: ...
9 years, 7 months ago (2011-05-11 08:42:07 UTC) #2
Sven Panne
http://codereview.chromium.org/6995024/diff/1/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): http://codereview.chromium.org/6995024/diff/1/src/hydrogen-instructions.cc#newcode423 src/hydrogen-instructions.cc:423: stream->Add("EVERYTHING"); On 2011/05/11 08:42:07, fschneider wrote: > "*" would ...
9 years, 7 months ago (2011-05-11 09:08:25 UTC) #3
danno
9 years, 7 months ago (2011-05-11 09:10:13 UTC) #4
LGTM

http://codereview.chromium.org/6995024/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):

http://codereview.chromium.org/6995024/diff/1/src/hydrogen-instructions.cc#ne...
src/hydrogen-instructions.cc:63: default:
I think the idea here is to have the compiler complain when something is added
to the enum? With your change, that's no longer the case.

Powered by Google App Engine
This is Rietveld 408576698