Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1638)

Issue 6995015: NaCl: Add the integrated runtime (IRT) library to Windows install images (Closed)

Created:
9 years, 7 months ago by Mark Seaborn
Modified:
9 years, 5 months ago
Reviewers:
bradn
CC:
chromium-reviews, pam+watch_chromium.org, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

NaCl: Add the integrated runtime (IRT) library to Windows install images The dependencies in mini_installer.gyp should be OK, because the target that produces chrome.exe also copies nacl_irt_* into <(PRODUCT_DIR) as a side effect. BUG=http://code.google.com/p/nativeclient/issues/detail?id=1595 TEST=not sure how to test this, apart from manually testing the install images that are produced after this is committed Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84826

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M chrome/installer/mini_installer.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/installer/mini_installer/chrome.release View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/tools/build/win/FILES View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Seaborn
This is split out from http://codereview.chromium.org/6927015/ and extended to change FILES.
9 years, 7 months ago (2011-05-10 11:57:01 UTC) #1
bradn
9 years, 7 months ago (2011-05-10 17:05:56 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698