Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6995007: iwyu: Use callback_old.h where appropriate, part 2. (Closed)

Created:
9 years, 7 months ago by James Hawkins
Modified:
9 years, 7 months ago
Reviewers:
Nico, awong
CC:
chromium-reviews, jam, ajwong+watch_chromium.org, Ilya Sherman, dhollowa, GeorgeY, ncarter (slow), idana, Erik does not do reviews, dmaclach+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, tim (not reviewing), Avi (use Gerrit), wez+watch_chromium.org, Raghu Simha, cbentzel+watch_chromium.org, simonmorris+watch_chromium.org, pam+watch_chromium.org, sergeyu+watch_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, garykac+watch_chromium.org, Aaron Boodman, lambroslambrou+watch_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

iwyu: Use callback_old.h where appropriate, part 2. BUG=none TEST=none R=thakis@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84753

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -34 lines) Patch
M base/callback_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browsing_data_indexed_db_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data_indexed_db_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browsing_data_local_storage_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_safe_browsing_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_accessibility_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/file_reader.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/top_sites_backend.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/icon_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/balloon_collection.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/remoting/directory_add_request.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/remoting/setup_flow_register_step.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store_file.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/service/service_process_control.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/base_session_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/model_changing_syncer_command.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/model_safe_worker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/syncapi.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/thumbnail_generator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/dragged_tab_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/autofill/form_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_dom_feature_extractor.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_term_feature_extractor.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/scorer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/print_system.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/worker_host/worker_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/command_buffer_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_gl_context.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/transport_texture_host.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/test_completion_callback.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/disk_cache/disk_cache_test_util.h View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/capturer.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/register_support_host_request.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
James Hawkins
9 years, 7 months ago (2011-05-10 01:20:26 UTC) #1
James Hawkins
+ajwong
9 years, 7 months ago (2011-05-10 01:23:51 UTC) #2
awong
LGTM On Mon, May 9, 2011 at 6:23 PM, <jhawkins@chromium.org> wrote: > +ajwong > > ...
9 years, 7 months ago (2011-05-10 01:26:28 UTC) #3
Nico
9 years, 7 months ago (2011-05-10 01:45:42 UTC) #4 
LGTM

On Mon, May 9, 2011 at 6:26 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote:

> LGTM
>
>
> On Mon, May 9, 2011 at 6:23 PM, <jhawkins@chromium.org> wrote:
>
>> +ajwong
>>
>>
>> http://codereview.chromium.org/6995007/
>>
>
>

Powered by Google App Engine
This is Rietveld 408576698