Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: printing/units_unittest.cc

Issue 6995006: printing: Replace "using namespace printing;" wrapping the tests around "namespace printing { ... }" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: use namespace printing instead ;) Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: printing/units_unittest.cc
diff --git a/printing/units_unittest.cc b/printing/units_unittest.cc
index 4b7f4bf52fef4483eea56d437bd9e30ad82d3a89..bf9915df95d737a205bd72e7b3f22f427efbbecc 100644
--- a/printing/units_unittest.cc
+++ b/printing/units_unittest.cc
@@ -6,7 +6,8 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/gtest/include/gtest/gtest-spi.h"
-using namespace printing;
+namespace printing {
+namespace {
Lei Zhang 2011/05/10 01:17:03 I don't think you need the anonymous namespace her
tfarina 2011/05/10 01:18:47 I think it's better to protect against http://en.w
tfarina 2011/05/10 01:25:48 Removed.
TEST(UnitsTest, Convertions) {
EXPECT_EQ(100, ConvertUnit(100, 100, 100));
@@ -59,3 +60,6 @@ TEST(UnitsTest, Convertions) {
EXPECT_EQ(8, ConvertPixelsToPoint(10));
EXPECT_EQ(0, ConvertPixelsToPoint(0));
}
+
+} // namespace
+} // namespace printing
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698