Fix password automation hooks to get pyauto test testSavePassword working.

chrome/test/functional/passwords.py

 #!/usr/bin/python
 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 
 import pyauto_functional  # Must be imported before pyauto
 import pyauto
 import test_utils
@@ skipping 36 matching lines @@
             'action_target': action_target,
             'blacklist': blacklist}
 
   def testSavePassword(self):
     """Test saving a password and getting saved passwords."""
     password1 = self._ConstructPasswordDictionary(
         'user@example.com', 'test.password',
         'https://www.example.com/', 'https://www.example.com/login',
         'username', 'password', 'https://www.example.com/login/')
     self.assertTrue(self.AddSavedPassword(password1))
-    self.assertEquals(self.GetSavedPasswords(), [password1])
+    # There may be multiple logins for the same 'signon_realm', since other

[Nirnimesh, 2011/05/10 19:25:52]

Wouldn't tests begin with a clean profile?

[dennis_jeffrey, 2011/05/17 01:40:21]

Yes, this is true in Windows and ChromeOS (the only platforms for which the
passwords tests are enabled).  I added a setUp() function to assert this on the
start of each test in this file.

+    # tests in this file use them.  We need to look for the particular login
+    # used by this test when verifiying.
+    saved_password = [x for x in self.GetSavedPasswords()
+                      if x['signon_realm'] == 'https://www.example.com/' and
+                      x['username_value'] == 'user@example.com']
+    self.assertEquals(saved_password, [password1])
 
   def testRemovePasswords(self):
     """Verify that saved passwords can be removed."""
     password1 = self._ConstructPasswordDictionary(
         'user1@example.com', 'test1.password',
         'https://www.example.com/', 'https://www.example.com/login',
         'username1', 'password', 'https://www.example.com/login/')
     password2 = self._ConstructPasswordDictionary(
         'user2@example.com', 'test2.password',
         'https://www.example.com/', 'https://www.example.com/login',
@@ skipping 199 matching lines @@
     self.ExecuteJavascript(set_focus, 0, 0)
     self._SendCharToPopulateField('t', tab_index=0, windex=0)
     passwd_value = self.GetDOMValue('document.getElementById("Passwd").value')
     self.assertFalse(passwd_value,
                      msg='Password field not empty for new username.')
     test_utils.ClearPasswords(self)
 
 
 if __name__ == '__main__':
   pyauto_functional.Main()